scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 06:52:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #1723 from mzgoddard/blocks-monitored-cache

Browse source 
Cache the set of actively monitored blocks
This commit is contained in:
Paul Kaplan 2018-11-14 14:16:36 -05:00 committed by GitHub
commit 8aa88fa2a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/engine/blocks.js
View file

@ -64,7 +64,14 @@ class Blocks {
* execute. * execute.
* @type {object.<string, object>} * @type {object.<string, object>}
*/ */
_executeCached: {} _executeCached: {},
/**
* A cache of block IDs and targets to start threads on as they are
* actively monitored.
* @type {Array<{blockId: string, target: Target}>}
*/
_monitored: null
}; };
/** /**
@ -492,6 +499,7 @@ class Blocks {
this._cache.procedureParamNames = {}; this._cache.procedureParamNames = {};
this._cache.procedureDefinitions = {}; this._cache.procedureDefinitions = {};
this._cache._executeCached = {}; this._cache._executeCached = {};
this._cache._monitored = null;
} }
/** /**
@ -702,14 +710,25 @@ class Blocks {
* @param {!object} runtime Runtime to run all blocks in. * @param {!object} runtime Runtime to run all blocks in.
*/ */
runAllMonitored (runtime) { runAllMonitored (runtime) {
Object.keys(this._blocks).forEach(blockId => { if (this._cache._monitored === null) {
if (this.getBlock(blockId).isMonitored) { this._cache._monitored = Object.keys(this._blocks)
.filter(blockId => this.getBlock(blockId).isMonitored)
.map(blockId => {
const targetId = this.getBlock(blockId).targetId; const targetId = this.getBlock(blockId).targetId;
runtime.addMonitorScript(blockId, targetId ? runtime.getTargetById(targetId) : null); return {
} blockId,
target: targetId ? runtime.getTargetById(targetId) : null
};
}); });
} }
const monitored = this._cache._monitored;
for (let i = 0; i < monitored.length; i++) {
const {blockId, target} = monitored[i];
runtime.addMonitorScript(blockId, target);
}
}
/** /**
* Block management: delete blocks and their associated scripts. Does nothing if a block * Block management: delete blocks and their associated scripts. Does nothing if a block
* with the given ID does not exist. * with the given ID does not exist.