scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-25 07:22:33 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Addressing PR comments.

Browse source
This commit is contained in:
Karishma Chadha 2018-04-29 19:52:21 -04:00
parent 271a19c05d
commit 857f77c511
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/io/video.js
View file

@ -65,7 +65,8 @@ class Video {
} }
/** /**
* Set a video provider for this device. * Set a video provider for this device. A default implementation of
* a video provider can be found in scratch-gui/src/lib/video/video-provider
* @param {VideoProvider} provider - Video provider to use * @param {VideoProvider} provider - Video provider to use
*/ */
setProvider (provider) { setProvider (provider) {
@ -89,8 +90,8 @@ class Video {
* @return {void} * @return {void}
*/ */
disableVideo () { disableVideo () {
if (!this.provider) return null;
this._disablePreview(); this._disablePreview();
if (!this.provider) return null;
this.provider.disableVideo(); this.provider.disableVideo();
} }
@ -114,9 +115,6 @@ class Video {
cacheTimeout = this._frameCacheTimeout cacheTimeout = this._frameCacheTimeout
}) { }) {
if (this.provider) return this.provider.getFrame({dimensions, mirror, format, cacheTimeout}); if (this.provider) return this.provider.getFrame({dimensions, mirror, format, cacheTimeout});
if (!this.videoReady) {
return null;
}
return null; return null;
} }