scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-01-10 15:02:06 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #16 from tmickel/bugfix/fix-move

Browse source 
Shuffle moveBlock to allow case where e.oldParent !== undefined
This commit is contained in:
Tim Mickel 2016-05-03 11:25:22 -04:00
commit 7eef10ef8c
3 changed files with 38 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
src/engine/runtime.js
View file

@ -130,8 +130,23 @@ Runtime.prototype.changeBlock = function (args) {
Runtime.prototype.moveBlock = function (e) { Runtime.prototype.moveBlock = function (e) {
var _this = this; var _this = this;
// Block has a new parent // Block was removed from parent
if (e.oldParent === undefined && e.newParent !== undefined) { if (e.newParent === undefined && e.oldParent !== undefined) {
// Add stack
_this.stacks.push(e.id);
// Update old parent
if (e.oldField === undefined) {
_this.blocks[e.oldParent].next = null;
} else {
delete _this.blocks[e.oldParent].fields[e.oldField];
}
} else if (e.newParent !== undefined) {
// Block was moved to a new parent
// Either happens because it was previously parentless
// (e.oldParent === undefined)
// or because a block was moved in front of it.
// Remove stack // Remove stack
_this._deleteStack(e.id); _this._deleteStack(e.id);
@ -146,19 +161,6 @@ Runtime.prototype.moveBlock = function (e) {
}; };
} }
} }
// Block was removed from parent
if (e.newParent === undefined && e.oldParent !== undefined) {
// Add stack
_this.stacks.push(e.id);
// Update old parent
if (e.oldField === undefined) {
_this.blocks[e.oldParent].next = null;
} else {
delete _this.blocks[e.oldParent].fields[e.oldField];
}
}
}; };
/** /**

32
vm.js
View file

@ -1308,8 +1308,23 @@
Runtime.prototype.moveBlock = function (e) { Runtime.prototype.moveBlock = function (e) {
var _this = this; var _this = this;
// Block has a new parent // Block was removed from parent
if (e.oldParent === undefined && e.newParent !== undefined) { if (e.newParent === undefined && e.oldParent !== undefined) {
// Add stack
_this.stacks.push(e.id);
// Update old parent
if (e.oldField === undefined) {
_this.blocks[e.oldParent].next = null;
} else {
delete _this.blocks[e.oldParent].fields[e.oldField];
}
} else if (e.newParent !== undefined) {
// Block was moved to a new parent
// Either happens because it was previously parentless
// (e.oldParent === undefined)
// or because a block was moved in front of it.
// Remove stack // Remove stack
_this._deleteStack(e.id); _this._deleteStack(e.id);
@ -1324,19 +1339,6 @@
}; };
} }
} }
// Block was removed from parent
if (e.newParent === undefined && e.oldParent !== undefined) {
// Add stack
_this.stacks.push(e.id);
// Update old parent
if (e.oldField === undefined) {
_this.blocks[e.oldParent].next = null;
} else {
delete _this.blocks[e.oldParent].fields[e.oldField];
}
}
}; };
/** /**

8
vm.min.js vendored
View file

File diff suppressed because one or more lines are too long