scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 15:02:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Set visible: false instead of deleting state in requestRemoveMonitor

Browse source 
This potentially has performance implications, to be investigated later.
This commit is contained in:
Connor Hudson 2018-06-06 17:14:09 -04:00
parent 0d0543810f
commit 77dda04228
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/engine/runtime.js
View file

@ -1561,7 +1561,13 @@ class Runtime extends EventEmitter {
* @param {!string} monitorId ID of the monitor to remove. * @param {!string} monitorId ID of the monitor to remove.
*/ */
requestRemoveMonitor (monitorId) { requestRemoveMonitor (monitorId) {
this._monitorState = this._monitorState.delete(monitorId); // this._monitorState = this._monitorState.delete(monitorId);
// TODO is this performant?
if (this._monitorState.has(monitorId)) {
this._monitorState = this._monitorState.set(
monitorId, this._monitorState.get(monitorId).merge({visible: false})
);
}
} }
/** /**