scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 06:52:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Log a warning if dataURI property is missing from image argument specification in extension info. Default to empty string if dataURI or alt are not provided.

Browse source
This commit is contained in:
Karishma Chadha 2019-09-20 16:56:02 -07:00
parent 167f502edc
commit 6afbe192d8
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/engine/runtime.js
View file

@ -1244,10 +1244,13 @@ class Runtime extends EventEmitter {
// check if this is not one of those cases. E.g. an inline image on a block. // check if this is not one of those cases. E.g. an inline image on a block.
if (argTypeInfo.type && !argTypeInfo.shadowType && !argTypeInfo.fieldType) { if (argTypeInfo.type && !argTypeInfo.shadowType && !argTypeInfo.fieldType) {
if (argTypeInfo.type === 'IMAGE') { if (argTypeInfo.type === 'IMAGE') {
if (!argInfo.dataURI) {
log.warn('Missing data URI in extension block with argument type IMAGE');
}
argJSON = { argJSON = {
type: 'field_image', type: 'field_image',
alt: argInfo.alt, alt: argInfo.alt || '',
src: argInfo.dataURI, src: argInfo.dataURI || '',
// TODO these probably shouldn't be hardcoded...? // TODO these probably shouldn't be hardcoded...?
width: 24, width: 24,
height: 24, height: 24,