Fix stack glows so that stacks glow as soon as the first block in the stack starts running as opposed to after the first block has finished. Make sure that monitored reporters in the flyout are not glowing.

This commit is contained in:
Karishma Chadha 2018-08-22 14:44:06 -04:00
parent 9242835be8
commit 62bf790d8f
3 changed files with 28 additions and 11 deletions
src/engine

View file

@ -475,6 +475,14 @@ const execute = function (sequencer, thread) {
// Fields are set during opCached initialization.
// Blocks should glow when a script is starting,
// not after it has finished (see #1404).
// Only blocks in blockContainers that don't forceNoGlow
// should request a glow.
if (!blockContainer.forceNoGlow) {
thread.requestScriptGlowInFrame = true;
}
// Inputs are set during previous steps in the loop.
let primitiveReportedValue = null;
@ -530,13 +538,6 @@ const execute = function (sequencer, thread) {
break;
} else if (thread.status === Thread.STATUS_RUNNING) {
if (lastOperation) {
if (typeof primitiveReportedValue === 'undefined') {
// No value reported - potentially a command block.
// Edge-activated hats don't request a glow; all
// commands do.
thread.requestScriptGlowInFrame = true;
}
handleReport(primitiveReportedValue, sequencer, thread, opCached, lastOperation);
} else {
// By definition a block that is not last in the list has a