scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-06-11 04:51:15 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Stop all sounds in the sound bank in stopAllSounds

Browse source
This commit is contained in:
apple502j 2020-04-20 02:48:07 +09:00
parent f5ce73ae51
commit 562b01a988
1 changed files with 13 additions and 2 deletions

15
src/blocks/scratch3_sound.js
View file

@ -229,8 +229,19 @@ class Scratch3SoundBlocks {
stopAllSounds () {
if (this.runtime.targets === null) return;
const allTargets = this.runtime.targets;
for (let i = 0; i < allTargets.length; i++) {
this._stopAllSoundsForTarget(allTargets[i]);
for (const target of allTargets) {
if (target.sprite.soundBank) {
// stopAllSounds default to ALL_TARGETS.
// This function is supposed to stop all sounds, so it should be fine.
// Because of some weird clone handlings, SoundBank.playerTargets can
// contain targets that are no longer in runtime.targets.
// For this reason, passing targets to stopAllSounds is unreliable,
// so _stopAllSoundsForTarget is not used.
target.sprite.soundBank.stopAllSounds();
if (this.waitingSounds[target.id]) {
this.waitingSounds[target.id].clear();
}
}
}
}