scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-25 07:22:33 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Merge pull request #1235 from kchadha/xml-escape-comments

Browse source 
XML escape comment text.
This commit is contained in:
kchadha 2018-06-14 14:46:02 -04:00 committed by GitHub
commit 529d271186
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/engine/comment.js
View file

@ -5,6 +5,7 @@
const uid = require('../util/uid'); const uid = require('../util/uid');
const Cast = require('../util/cast'); const Cast = require('../util/cast');
const xmlEscape = require('../util/xml-escape');
class Comment { class Comment {
/** /**
@ -31,7 +32,7 @@ class Comment {
toXML () { toXML () {
return `<comment id="${this.id}" x="${this.x}" y="${ return `<comment id="${this.id}" x="${this.x}" y="${
this.y}" w="${this.width}" h="${this.height}" pinned="${ this.y}" w="${this.width}" h="${this.height}" pinned="${
this.blockId !== null}" minimized="${this.minimized}">${this.text}</comment>`; this.blockId !== null}" minimized="${this.minimized}">${xmlEscape(this.text)}</comment>`;
} }
// TODO choose min and defaults for width and height // TODO choose min and defaults for width and height