scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-23 14:32:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Hoist target list assignment to simplify code.

Browse source
This commit is contained in:
Paul Kaplan 2018-06-13 10:09:22 -04:00
parent 0ec0ea6ef7
commit 4b64df222a
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/virtual-machine.js
View file

@ -1041,11 +1041,11 @@ class VirtualMachine extends EventEmitter {
* @returns {boolean} Whether a target was reordered.
*/
reorderTarget (targetIndex, newIndex) {
targetIndex = MathUtil.clamp(targetIndex, 0, this.runtime.targets.length - 1);
newIndex = MathUtil.clamp(newIndex, 0, this.runtime.targets.length - 1);
if (targetIndex === newIndex) return false;
const target = this.runtime.targets[targetIndex];
let targets = this.runtime.targets;
targetIndex = MathUtil.clamp(targetIndex, 0, targets.length - 1);
newIndex = MathUtil.clamp(newIndex, 0, targets.length - 1);
if (targetIndex === newIndex) return false;
const target = targets[targetIndex];
targets = targets.slice(0, targetIndex).concat(targets.slice(targetIndex + 1));
targets.splice(newIndex, 0, target);
this.runtime.targets = targets;