scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-23 06:23:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Remove one copy of constants

Browse source
This commit is contained in:
Valerie Young 2019-01-10 10:11:46 -05:00
parent 5d4aebf301
commit 477c307304
2 changed files with 7 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/extensions/scratch3_gdx_for/index.js
View file

@ -140,7 +140,7 @@ class GdxFor {
* @private
*/
_onConnect () {
const adapter = new ScratchLinkDeviceAdapter(this._scratchLinkSocket);
const adapter = new ScratchLinkDeviceAdapter(this._scratchLinkSocket, BLEUUID);
godirect.createDevice(adapter, {open: true, startMeasurements: false}).then(device => {
this._device = device;
this._startMeasurements();

20
src/extensions/scratch3_gdx_for/scratch-link-device-adapter.js
View file

@ -1,23 +1,15 @@
const Base64Util = require('../../util/base64-util');
/**
* Enum for Vernier godirect protocol.
* @readonly
* @enum {string}
*/
const BLEUUID = {
service: 'd91714ef-28b9-4f91-ba16-f0d9a604f112',
commandChar: 'f4bf14a6-c7d5-4b6d-8aa8-df1a7c83adcb',
responseChar: 'b41e6675-a329-40e0-aa01-44d2f444babe'
};
/**
* Adapter class
*/
class ScratchLinkDeviceAdapter {
constructor (scratchLinkSocket) {
constructor (scratchLinkSocket, { service, commandChar, responseChar }) {
this.scratchLinkSocket = scratchLinkSocket;
this._service = service;
this._commandChar = commandChar;
this._responseChar = responseChar;
this._onResponse = this._onResponse.bind(this);
this._deviceOnResponse = null;
}
@ -30,13 +22,13 @@ class ScratchLinkDeviceAdapter {
const data = Base64Util.uint8ArrayToBase64(commandBuffer);
return this.scratchLinkSocket
.write(BLEUUID.service, BLEUUID.commandChar, data, 'base64', true);
.write(this._service, this._commandChar, data, 'base64', true);
}
setup ({onResponse}) {
this._deviceOnResponse = onResponse;
return this.scratchLinkSocket
.startNotifications(BLEUUID.service, BLEUUID.responseChar, this._onResponse);
.startNotifications(this._service, this._responseChar, this._onResponse);
// TODO:
// How do we find out from scratch link if communication closes?