scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-06-03 17:14:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions1

Merge pull request from paulkaplan/do-save-tl-var-blocks

Browse source 
Add a test and fix for not serializing top-level variable reporters
This commit is contained in:
Paul Kaplan 2018-12-06 05:32:23 -05:00 • committed by GitHub
commit 4756726e43
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 21 additions and 2 deletions

BIN
test/fixtures/top-level-variable-reporter.sb2 vendored Normal file
View file

Binary file not shown.

19
test/unit/serialization_sb3.js
View file

@ -7,6 +7,7 @@ const exampleProjectPath = path.resolve(__dirname, '../fixtures/clone-cleanup.sb
const commentsSB2ProjectPath = path.resolve(__dirname, '../fixtures/comments.sb2');
const commentsSB3ProjectPath = path.resolve(__dirname, '../fixtures/comments.sb3');
const commentsSB3NoDupeIds = path.resolve(__dirname, '../fixtures/comments_no_duplicate_id_serialization.sb3');
const variableReporterSB2ProjectPath = path.resolve(__dirname, '../fixtures/top-level-variable-reporter.sb2');
const FakeRenderer = require('../fixtures/fake-renderer');
test('serialize', t => {
@ -236,3 +237,21 @@ test('getExtensionIdForOpcode', t => {
t.end();
});
test('(#1608) serializeBlocks maintains top level variable reporters', t => {
const vm = new VirtualMachine();
vm.loadProject(readFileToBuffer(variableReporterSB2ProjectPath))
.then(() => {
const blocks = vm.runtime.targets[0].blocks._blocks;
const result = sb3.serialize(vm.runtime);
// Project should have 1 block, a top-level variable reporter
t.equal(Object.keys(blocks).length, 1);
t.equal(Object.keys(result.targets[0].blocks).length, 1);
// Make sure deserializing these blocks works
t.doesNotThrow(() => {
sb3.deserialize(JSON.parse(JSON.stringify(result)), vm.runtime);
});
t.end();
});
});