From 471a22dbdcdaafdc86c4901ff3a300cf4ea9a8b1 Mon Sep 17 00:00:00 2001 From: Evelyn Eastmond Date: Sun, 23 Jun 2019 21:58:05 -0400 Subject: [PATCH] Clarifying input_device_list args and return types. --- src/extensions/scratch3_ev3/index.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/extensions/scratch3_ev3/index.js b/src/extensions/scratch3_ev3/index.js index ae0ba679e..c543e6eb6 100644 --- a/src/extensions/scratch3_ev3/index.js +++ b/src/extensions/scratch3_ev3/index.js @@ -97,7 +97,8 @@ const Ev3Args = { COAST: 0x00, BRAKE: 0x01, RAMP: 50, // time in milliseconds - DO_NOT_CHANGE_TYPE: 0 + DO_NOT_CHANGE_TYPE: 0, + MAX_DEVICES: 32 // 'Normally 32' from pg. 46 }; /** @@ -737,9 +738,9 @@ class EV3 { if (this._pollingCounter % 20 === 0) { // GET DEVICE LIST cmds[0] = Ev3Opcode.OPINPUT_DEVICE_LIST; - cmds[1] = Ev3ParamEncoding.ONE_BYTE; // TODO: Length? - cmds[2] = Ev3ParamEncoding.GLOBAL_CONSTANT_INDEX_1; // TODO: Array is 0x21? - cmds[3] = Ev3ParamEncoding.GLOBAL_VARIABLE_INDEX_0; // TODO: Changed is 0x60? + cmds[1] = Ev3ParamEncoding.ONE_BYTE; + cmds[2] = Ev3Args.MAX_DEVICES; + cmds[3] = Ev3ParamEncoding.GLOBAL_VARIABLE_INDEX_0; cmds[4] = Ev3ParamEncoding.GLOBAL_ONE_BYTE; cmds[5] = Ev3ParamEncoding.GLOBAL_CONSTANT_INDEX_0;