scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-01-25 17:09:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix stack check in stepThread

Browse source 
The previous logic seemed to be expecting `peekStack` to return 0 when
the stack was empty, but its return type is `?string` and it returns
`undefined` when the stack is empty. The `!== 0` check would never pass,
then, leading to problems with (for example) the "say/think and wait"
blocks.
This commit is contained in:
Christopher Willis-Ford 2018-03-14 16:17:29 -07:00
parent b5d7602f4f
commit 4210c6dd4c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/engine/sequencer.js
View file

@ -175,7 +175,7 @@ class Sequencer {
thread.popStack(); thread.popStack();
} }
// Save the current block ID to notice if we did control flow. // Save the current block ID to notice if we did control flow.
while ((currentBlockId = thread.peekStack()) !== 0) { while ((currentBlockId = thread.peekStack())) {
let isWarpMode = thread.peekStackFrame().warpMode; let isWarpMode = thread.peekStackFrame().warpMode;
if (isWarpMode && !thread.warpTimer) { if (isWarpMode && !thread.warpTimer) {
// Initialize warp-mode timer if it hasn't been already. // Initialize warp-mode timer if it hasn't been already.