diff --git a/src/engine/blocks.js b/src/engine/blocks.js index 85ef3b204..8234a6e24 100644 --- a/src/engine/blocks.js +++ b/src/engine/blocks.js @@ -295,9 +295,8 @@ class Blocks { oldInput: e.oldInputName, newParent: e.newParentId, newInput: e.newInputName, - newCoordinate: e.newCoordinate, - oldCoordinate: e.oldCoordinate - }, optRuntime); + newCoordinate: e.newCoordinate + }); break; case 'dragOutside': if (optRuntime) { @@ -374,22 +373,16 @@ class Blocks { } const comment = currTarget.comments[e.commentId]; const change = e.newContents_; - if (typeof change === 'object') { - if (change.hasOwnProperty('minimized')) { - comment.minimized = change.minimized; - break; - } else if (change.hasOwnProperty('width') && change.hasOwnProperty('height')){ - comment.width = change.width; - comment.height = change.height; - break; - } - } else if (typeof change === 'string') { - comment.text = change; - break; + if (change.hasOwnProperty('minimized')) { + comment.minimized = change.minimized; + } + if (change.hasOwnProperty('width') && change.hasOwnProperty('height')){ + comment.width = change.width; + comment.height = change.height; + } + if (change.hasOwnProperty('text')) { + comment.text = change.text; } - log.warn(`Unrecognized comment change: ${ - JSON.stringify(change)} for comment with id: ${e.commentId}.`); - return; } break; case 'comment_move': @@ -552,10 +545,8 @@ class Blocks { /** * Block management: move blocks from parent to parent * @param {!object} e Blockly move event to be processed - * @param {?Runtime} optRuntime Optional runtime for updating the position - * of a comment on the block that moved. */ - moveBlock (e, optRuntime) { + moveBlock (e) { if (!this._blocks.hasOwnProperty(e.id)) { return; } @@ -564,19 +555,6 @@ class Blocks { if (e.newCoordinate) { this._blocks[e.id].x = e.newCoordinate.x; this._blocks[e.id].y = e.newCoordinate.y; - - // If the moved block has a comment, update the position of the comment. - if (typeof this._blocks[e.id].comment === 'string' && optRuntime && - e.oldCoordinate) { - const commentId = this._blocks[e.id].comment; - const currTarget = optRuntime.getEditingTarget(); - if (currTarget && currTarget.comments.hasOwnProperty(commentId)) { - const deltaX = e.newCoordinate.x - e.oldCoordinate.x; - const deltaY = e.newCoordinate.y - e.oldCoordinate.y; - currTarget.comments[commentId].x += deltaX; - currTarget.comments[commentId].y += deltaY; - } - } } // Remove from any old parent.