Respond to review comments

- Pin `got` and `socket-io.client`
- Finish removing `removeSocket`-related code
This commit is contained in:
Christopher Willis-Ford 2017-05-05 10:37:29 -07:00
parent e096f43487
commit 35d0544ce0
2 changed files with 2 additions and 4 deletions

View file

@ -34,7 +34,7 @@
"eslint-config-scratch": "^3.1.0",
"expose-loader": "0.7.3",
"gh-pages": "^0.12.0",
"got": "^5.7.1",
"got": "5.7.1",
"highlightjs": "^9.8.0",
"htmlparser2": "3.9.2",
"json": "^9.0.4",
@ -46,7 +46,7 @@
"scratch-render": "latest",
"scratch-storage": "latest",
"script-loader": "0.7.0",
"socket.io-client": "^1.7.3",
"socket.io-client": "1.7.3",
"stats.js": "^0.17.0",
"tap": "^10.2.0",
"travis-after-all": "^1.4.4",

View file

@ -86,7 +86,6 @@ class DeviceOpener {
* React to the socket becoming disconnected.
*/
onDisconnect () {
this.removeSocket();
this.clearConnectionTimeout();
this._reject('device disconnected');
}
@ -102,7 +101,6 @@ class DeviceOpener {
if (this._socket.connected) {
this._socket.disconnect();
} else {
this.removeSocket();
this._reject('connection attempt timed out');
}
}