Check specifically for number in optional property

This commit is contained in:
Paul Kaplan 2018-06-06 09:33:23 -04:00
parent 837703d4ac
commit 1ebb736a2a

View file

@ -488,10 +488,10 @@ class RenderedTarget extends Target {
* @param {?int} index Index at which to add costume * @param {?int} index Index at which to add costume
*/ */
addCostume (costumeObject, index) { addCostume (costumeObject, index) {
if (typeof index === 'undefined') { if (typeof index === 'number' && !isNaN(index)) {
this.sprite.addCostumeAt(costumeObject, this.sprite.costumes.length);
} else {
this.sprite.addCostumeAt(costumeObject, index); this.sprite.addCostumeAt(costumeObject, index);
} else {
this.sprite.addCostumeAt(costumeObject, this.sprite.costumes.length);
} }
} }
@ -551,10 +551,10 @@ class RenderedTarget extends Target {
addSound (soundObject, index) { addSound (soundObject, index) {
const usedNames = this.sprite.sounds.map(sound => sound.name); const usedNames = this.sprite.sounds.map(sound => sound.name);
soundObject.name = StringUtil.unusedName(soundObject.name, usedNames); soundObject.name = StringUtil.unusedName(soundObject.name, usedNames);
if (typeof index === 'undefined') { if (typeof index === 'number' && !isNaN(index)) {
this.sprite.sounds.push(soundObject);
} else {
this.sprite.sounds.splice(index, 0, soundObject); this.sprite.sounds.splice(index, 0, soundObject);
} else {
this.sprite.sounds.push(soundObject);
} }
} }