scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2024-12-24 15:02:52 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Ensure music extension _decodeSound is promise

Browse source 
Currently if there is no audio engine detected this returns undefined,
which in turn causes the line above to fail trying to call `.then` on
it.
This commit is contained in:
Corey Frang 2018-03-08 12:32:01 -05:00
parent cc2bf1dfc7
commit 1d414dd5a0
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/extensions/scratch3_music/index.js
View file

@ -125,10 +125,11 @@ class Scratch3MusicBlocks {
* @return {Promise} - a promise which will resolve once the sound has decoded. * @return {Promise} - a promise which will resolve once the sound has decoded.
*/ */
_decodeSound (soundBuffer) { _decodeSound (soundBuffer) {
if (!this.runtime.audioEngine) return; const context = this.runtime.audioEngine && this.runtime.audioEngine.audioContext;
if (!this.runtime.audioEngine.audioContext) return;
const context = this.runtime.audioEngine.audioContext; if (!context) {
return Promise.reject(new Error('No Audio Context Detected'));
}
// Check for newer promise-based API // Check for newer promise-based API
if (context.decodeAudioData.length === 1) { if (context.decodeAudioData.length === 1) {