From d0f1b77209cbe961196ef0db574ef7cf18b86ff6 Mon Sep 17 00:00:00 2001 From: Rasmus Haglund Date: Fri, 5 May 2017 21:58:18 +0200 Subject: [PATCH 1/2] Copy _customState for now until blocks have init functions --- src/sprites/rendered-target.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sprites/rendered-target.js b/src/sprites/rendered-target.js index e6323ec73..ad23003c7 100644 --- a/src/sprites/rendered-target.js +++ b/src/sprites/rendered-target.js @@ -696,6 +696,7 @@ class RenderedTarget extends Target { newClone.effects = JSON.parse(JSON.stringify(this.effects)); newClone.variables = JSON.parse(JSON.stringify(this.variables)); newClone.lists = JSON.parse(JSON.stringify(this.lists)); + newClone._customState = JSON.parse(JSON.stringify(this._customState)); newClone.initDrawable(); newClone.updateAllDrawableProperties(); // Place behind the current target. From 97bfc9035117c519cd5092ff2de8f7a045406d10 Mon Sep 17 00:00:00 2001 From: DD Liu Date: Wed, 10 May 2017 11:22:03 -0400 Subject: [PATCH 2/2] add comment to monitor block listener filtering of events --- src/virtual-machine.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/virtual-machine.js b/src/virtual-machine.js index c56e289c0..b39d74d8a 100644 --- a/src/virtual-machine.js +++ b/src/virtual-machine.js @@ -350,6 +350,8 @@ class VirtualMachine extends EventEmitter { * @param {!Blockly.Event} e Any Blockly event. */ monitorBlockListener (e) { + // Filter events by type, since monitor blocks only need to listen to these events. + // Monitor blocks shouldn't be destroyed when flyout blocks are deleted. if (['create', 'change'].indexOf(e.type) !== -1) { this.runtime.monitorBlocks.blocklyListen(e, this.runtime); }