scratchfoundation/scratch-vm
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-vm.git synced 2025-01-11 10:39:56 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor: use better whitespace-test for backdrops too

Browse source
This commit is contained in:
jokebookservice1 2018-10-10 19:45:36 +01:00
parent 1a7ce093c3
commit 0c18b4952d
No known key found for this signature in database
GPG key ID: A872407E9C478467
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/blocks/scratch3_looks.js
View file

@ -403,8 +403,10 @@ class Scratch3LooksBlocks {
if (selectedIndex === stage.currentCostume) selectedIndex += 1; if (selectedIndex === stage.currentCostume) selectedIndex += 1;
stage.setCostume(selectedIndex); stage.setCostume(selectedIndex);
} }
} else if (!isNaN(requestedBackdrop) && // Try to cast the string to a number (and treat it as a costume index)
(typeof requestedBackdrop !== 'string' || /\d/g.test(requestedBackdrop))) { // Pure whitespace should not be treated as a number (JS casts this to 0)
// Note: isNaN will cast the string to a number before checking if it's NaN
} else if (!(isNaN(requestedBackdrop) || Cast.isWhiteSpace(requestedBackdrop))) {
stage.setCostume(optZeroIndex ? Number(requestedBackdrop) : Number(requestedBackdrop) - 1); stage.setCostume(optZeroIndex ? Number(requestedBackdrop) : Number(requestedBackdrop) - 1);
} }
} }