scratchfoundation/scratch-render
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-render.git synced 2025-06-10 12:30:45 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions3

Merge pull request from fsih/renderTakeOff2Factor

Browse source 
Pass in factor of 2 instead of having magic 2s
This commit is contained in:
DD Liu 2018-04-27 10:26:41 -04:00 • committed by GitHub
commit a153a72e5b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 7 deletions

11
src/RenderWebGL.js
View file

@ -302,21 +302,18 @@ class RenderWebGL extends EventEmitter {
* Update an existing bitmap skin, or create a bitmap skin if the previous skin was not bitmap.
* @param {!int} skinId the ID for the skin to change.
* @param {!string} imgData - new bitmap to use.
* @param {!number} bitmapResolution - the resolution scale for a bitmap costume.
* @param {?Array<number>} rotationCenter Optional: rotation center of the skin. If not supplied, the center of the
* skin will be used
*/
updateBitmapSkin (skinId, imgData, rotationCenter) {
// Divide rotation center by 2 and set bitmap resolution = 2 because all images coming from paint editor
// are double resolution
const updatedRotationCenter = rotationCenter ?
[Math.floor(rotationCenter[0] / 2), Math.floor(rotationCenter[1] / 2)] : null;
updateBitmapSkin (skinId, imgData, bitmapResolution, rotationCenter) {
if (this._allSkins[skinId] instanceof BitmapSkin) {
this._allSkins[skinId].setBitmap(imgData, 2, updatedRotationCenter);
this._allSkins[skinId].setBitmap(imgData, bitmapResolution, rotationCenter);
return;
}
const newSkin = new BitmapSkin(skinId, this);
newSkin.setBitmap(imgData, 2, updatedRotationCenter);
newSkin.setBitmap(imgData, bitmapResolution, rotationCenter);
this._reskin(skinId, newSkin);
}