Commit graph

602 commits

Author SHA1 Message Date
chrisgarrity
97f669423a
Make PaintEditor component rtl aware (#617)
* Make PaintEditor component rtl aware

Fixes the color-picker and any other popover elements.

Adds an RTL prop to the PaintEditor that initializes the `layout` state in redux. Any other components that need to know the layout refer to the state in redux.

I debated whether the state should just be a boolean (true for RTL), or ‘rtl’, ‘ltr’. I went with the latter, but could be convinced that boolean would be better.

I did not add `dir=“rtl”` to the font picker dropdown as all the names are in LTR languages.

Question: Should the sliders reverse direction, and if so, is it worth doing right now when the layout of the color picker may change.

Adding the rtl prop and the `dir=…` to the PaintEditorComponent fixes layout issues in the playground.

* Don’t reverse gradient swatches: the fill colors (and swatch preview) should represent the way the left-right colors will blend when filling a shape.
2018-08-23 19:08:56 -04:00
chrisgarrity
620dd6ae49
Mirror margins, borders and arrow icons for RTL (#616)
* Mirror margins, borders and arrow icons for RTL

This handles everything exception the color picker.

I verified that things like the paint brush and magnifying glass should not be mirrored (even people who read Hebrew are usually right-handed)

* Fix dropdown icon padding in RTL
2018-08-22 13:13:46 -04:00
DD Liu
50de05cee4
Scrollbars (#602) 2018-08-16 16:49:43 -04:00
DD Liu
2791866a9e
Reduce tolerance across the board. Don't accept hit results on helper items unless they are handles. (#597) 2018-08-16 13:09:26 -04:00
DD Liu
8267e11176
Double click in select modes switches to text tool (#583) 2018-08-09 10:55:44 -04:00
Jacco Kulman
8056a788e7 Loupe issues fixed #378 (#382) 2018-08-08 18:27:01 -04:00
apple502j
5c723e5f92 Localize tool tooltips (#573)
* Create messages.js for all tooltips as many are shared between the bitmap and vector editors:
  * Brush Translation
  * Eraser Translation
  * Fill Translation
  * Line Translation
  * Oval Translation
  * Rect Translation
  * Reshape Translation
  * RoundedRect Translation
  * Select Translation
  * Text Translation
2018-08-06 09:16:35 -04:00
DD Liu
6c84cbf76d
Selection limit (#572) 2018-08-03 13:10:45 -04:00
DD Liu
df88d56d1b
Save bitmap selection (#569) 2018-07-25 19:07:35 -04:00
DD Liu
f7ca2c7e43
Leftover selection boxes (#570) 2018-07-25 16:28:55 -04:00
chrisgarrity
28ad90c9fe
Merge pull request #560 from chrisgarrity/issue/543-localize
Adjust format for different locales
2018-07-18 14:31:09 -04:00
chrisgarrity
ec38552b32 Fix icon alignment when there are no labels 2018-07-18 14:21:39 -04:00
DD Liu
af3c6694d4
Bitmap gradient (#559) 2018-07-17 17:21:02 -04:00
DD Liu
4ba79cacbb
Vector gradient (#558) 2018-07-17 16:37:03 -04:00
chrisgarrity
0ed3aaf3db Adjust format for different locales
* increased fullsize editor width, English required 1272, adding a couple more pixels allowed a couple of other languages to keep labels
* hide flip vertical/horizonal labels for everything except English
* hide all labels for languages defined in `hideLabel`
2018-07-16 14:34:36 -04:00
DD Liu
21f3a5f30c
Add missing props validation (#556) 2018-07-13 10:55:36 -04:00
DD Liu
4e4bb396a6
Draw oval and rectangle outlines in bitmap (#550) 2018-07-12 15:48:30 -04:00
Paul Kaplan
11bab6ebe2
Merge pull request #553 from paulkaplan/fix-conversion-button-styles
Make the bitmap/vector conversion button look enabled
2018-07-12 10:38:47 -04:00
Paul Kaplan
1d63bafedd Make the bitmap conversion button enabled always 2018-07-12 10:27:14 -04:00
DD Liu
652a3ca89b
Update image when deleting points (#551) 2018-07-11 14:10:03 -04:00
DD Liu
7063d359eb
Correct the view bounds when the paper canvas is initialized. (#549) 2018-07-11 11:13:27 -04:00
Paul Kaplan
179c68378b
Merge pull request #545 from paulkaplan/delete-button
Delete button
2018-07-09 09:17:37 -04:00
Paul Kaplan
64b71703ce Simplify the logic for reshape delete 2018-07-09 09:17:15 -04:00
Paul Kaplan
501f9806e6 Make fill and outline labels go above color buttons 2018-07-06 15:32:31 -04:00
DD Liu
90bc640dbb Fix reshape 2018-07-06 11:29:06 -04:00
Paul Kaplan
20228dfe0a Check for curved points as well as selected items for reshape delete 2018-07-06 11:27:48 -04:00
Paul Kaplan
fb460e3eb3 Add delete button for reshape tool also
The delete code already handles the pointwise deletion correctly, just needed to add it to the tool row
2018-07-05 14:17:20 -04:00
Paul Kaplan
a837b9ced6 Add delete button to mode tools for select tool 2018-07-05 14:16:43 -04:00
Paul Kaplan
74196228f1
Merge pull request #542 from paulkaplan/increase-tool-visibility
Increase selected tool visibility by making the icon white and bg blue.
2018-07-05 08:55:29 -04:00
Paul Kaplan
e772907023 Increase selected tool visibility by making the icon white and bg blue.
Resolves #375
2018-06-29 08:30:47 -04:00
Paul Kaplan
06a3ab7390
Merge pull request #537 from fsih/bitSelectTool
Bitmap select tool
2018-06-29 07:50:44 -04:00
DD Liu
e215b8a9b8 Fix issue with pasting vector into bitmap 2018-06-28 17:52:15 -04:00
Paul Kaplan
400f31e7ab Use the tool description as the button title to improve accessibility. 2018-06-28 09:54:49 -04:00
DD Liu
e2cc5e46b0 Merge branch 'develop' into bitSelectTool 2018-06-28 02:18:01 -04:00
DD Liu
d7bd6280ed clean up 2018-06-28 02:04:24 -04:00
DD Liu
0483d65413 Fix paste and transform bugs 2018-06-28 01:54:05 -04:00
DD Liu
eed84d8cf2 Handle flip in bitmap 2018-06-28 00:21:01 -04:00
DD Liu
a04088898e keep reference to selection 2018-06-27 23:42:29 -04:00
DD
ddca91a567 Fix the undo bug, but this time it's more real 2018-06-27 15:29:13 -04:00
Florrie
0176dd7eed Fix scroll speed on Firefox (#532)
Copied from https://github.com/LLK/scratch-blocks/pull/1427/
2018-06-26 16:15:50 -04:00
DD
7aa74d7ffd wip 2018-06-26 16:04:38 -04:00
DD Liu
093c3d03bb
Redo fill logic (#525) 2018-06-26 14:53:03 -04:00
DD
8759a3306f Keep scaled down images from becoming blurry 2018-06-25 19:37:47 -04:00
DD
f4df0e07af Redo fill logic 2018-06-25 16:57:56 -04:00
DD
57e3f3c8cb Handle undo 2018-06-25 11:51:33 -04:00
DD
a0faa1418e Fix flipped resizing 2018-06-21 10:43:41 -04:00
DD Liu
9c73d1a7d9 Add files 2018-06-21 10:22:24 -04:00
DD
644655d25e Bitmap select tool 2018-06-20 21:26:40 -04:00
DD Liu
d7298c0c43
Bit text tool (#515) 2018-06-19 14:54:29 -04:00
DD Liu
a70f8e1f36
Bitmap Oval tool (#516) 2018-06-19 14:20:06 -04:00