From e2e4823642488a3632d397299f270402cecc4e8c Mon Sep 17 00:00:00 2001 From: Paul Kaplan Date: Fri, 13 Oct 2017 14:24:07 -0400 Subject: [PATCH] Fix with feedback from DD --- src/components/color-picker.css | 2 +- src/components/color-picker.jsx | 2 ++ src/reducers/fill-color.js | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/color-picker.css b/src/components/color-picker.css index 49b79881..5ef9b537 100644 --- a/src/components/color-picker.css +++ b/src/components/color-picker.css @@ -1,5 +1,4 @@ /* Popover styles */ -/* @TODO need to fix tip border issue */ :global(.Popover-body) { background: white; border: 1px solid #ddd; @@ -8,6 +7,7 @@ padding: 4px; box-shadow: 0px 0px 8px 1px rgba(0, 0, 0, .3); } + :global(.Popover-tipShape) { fill: white; stroke: #ddd; diff --git a/src/components/color-picker.jsx b/src/components/color-picker.jsx index e3af2d56..4e1217a0 100644 --- a/src/components/color-picker.jsx +++ b/src/components/color-picker.jsx @@ -84,6 +84,8 @@ class ColorPickerComponent extends React.Component { _makeBackground (channel) { const stops = []; + // Generate the color slider background CSS gradients by adding + // color stops depending on the slider. for (let n = 100; n >= 0; n -= 10) { switch (channel) { case 'hue': diff --git a/src/reducers/fill-color.js b/src/reducers/fill-color.js index 6f9af076..fb7d7642 100644 --- a/src/reducers/fill-color.js +++ b/src/reducers/fill-color.js @@ -3,7 +3,7 @@ import {CHANGE_SELECTED_ITEMS} from './selected-items'; import {getColorsFromSelection} from '../helper/style-path'; const CHANGE_FILL_COLOR = 'scratch-paint/fill-color/CHANGE_FILL_COLOR'; -const initialState = '#aa0551'; +const initialState = '#000'; // Matches hex colors const regExp = /^#([0-9a-f]{3}){1,2}$/i;