scratchfoundation/scratch-paint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-paint.git synced 2025-01-09 06:02:05 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add comment, and adjust handleChange()

Browse source 
make `e.target.value` the submitted thing, rather than `this.props.value`
This commit is contained in:
Matthew Taylor 2017-10-25 14:15:02 -04:00
parent 90c485ba23
commit 3574918f23
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/components/forms/buffered-input-hoc.jsx
View file

@ -2,6 +2,10 @@
@todo This file is copied from GUI and should be pulled out into a shared library.
See https://github.com/LLK/scratch-paint/issues/13 */
/* ACTUALLY, THIS HAS BEEN EDITED ;)
handleChange() was adjusted here to actually send a change to `onSubmit()` so that
brush/eraser sizes change immediately on a numeric input*/
import bindAll from 'lodash.bindall';
import PropTypes from 'prop-types';
import React from 'react';
@ -40,9 +44,9 @@ export default function (Input) {
}
handleChange (e) {
const isNumeric = typeof this.props.value === 'number';
const validatesNumeric = isNumeric ? !isNaN(this.state.value) : true;
if (this.state.value !== null && validatesNumeric) {
this.props.onSubmit(isNumeric ? Number(this.state.value) : this.state.value);
const validatesNumeric = isNumeric ? !isNaN(e.target.value) : true;
if (e.target.value !== null && validatesNumeric) {
this.props.onSubmit(isNumeric ? Number(e.target.value) : e.target.value);
}
this.setState({value: e.target.value});
}