scratchfoundation/scratch-paint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-paint.git synced 2024-12-22 13:32:28 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Merge pull request #997 from adroitwhiz/adjust-reshape-tolerance

Browse source 
Adjust reshape mode handle tolerance
This commit is contained in:
adroitwhiz 2020-06-09 13:19:00 -04:00 committed by GitHub
commit 2a1eaa8926
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/helper/selection-tools/reshape-tool.js
View file

@ -33,7 +33,19 @@ const ReshapeModes = keyMirror({
class ReshapeTool extends paper.Tool {
/** Distance within which mouse is considered to be hitting an item */
static get TOLERANCE () {
return 4;
return ReshapeTool.HANDLE_RADIUS + ReshapeTool.HANDLE_PADDING;
}
/**
* Units of padding around the visible handle area that will still register clicks as "touching the handle"
*/
static get HANDLE_PADDING () {
return 1;
}
/**
* Handles' radius, including the stroke
*/
static get HANDLE_RADIUS () {
return 5.25;
}
/** Clicks registered within this amount of time are registered as double clicks */
static get DOUBLE_CLICK_MILLIS () {
@ -74,7 +86,10 @@ class ReshapeTool extends paper.Tool {
this.onKeyUp = this.handleKeyUp;
this.onKeyDown = this.handleKeyDown;
paper.settings.handleSize = 8;
// A handle's size is given in diameter, and each handle has a 2.5-pixel stroke that isn't part of its size:
// https://github.com/LLK/paper.js/blob/a187e4c81cc63f3d48c5097b9a9fbddde9f057da/src/item/Item.js#L4480
// Size the handles such that clicking on either the stroke or the handle itself will be registered as a drag
paper.settings.handleSize = (ReshapeTool.HANDLE_RADIUS * 2) - 2.5;
}
/**
* Returns the hit options for segments to use when conducting hit tests. Segments are only visible