scratchfoundation/scratch-paint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-paint.git synced 2024-12-23 05:52:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Add SVG id prop to track costume changes

Browse source 
Since the editor will receive an update every time the svg is updated, only re-render if the actual svg id changes.
This commit is contained in:
Ray Schamp 2017-10-21 02:57:15 -04:00
parent 303b4caced
commit 138718008c
4 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/paint-editor/paint-editor.jsx
View file

@ -169,6 +169,7 @@ class PaintEditorComponent extends React.Component {
rotationCenterX={this.props.rotationCenterX}
rotationCenterY={this.props.rotationCenterY}
svg={this.props.svg}
svgId={this.props.svgId}
/>
</div>
</div>
@ -186,7 +187,8 @@ PaintEditorComponent.propTypes = {
onUpdateSvg: PropTypes.func.isRequired,
rotationCenterX: PropTypes.number,
rotationCenterY: PropTypes.number,
svg: PropTypes.string
svg: PropTypes.string,
svgId: PropTypes.string
};
export default injectIntl(PaintEditorComponent);

2
src/containers/paint-editor.jsx
View file

@ -58,6 +58,7 @@ class PaintEditor extends React.Component {
rotationCenterX={this.props.rotationCenterX}
rotationCenterY={this.props.rotationCenterY}
svg={this.props.svg}
svgId={this.props.svgId}
onRedo={this.handleRedo}
onUndo={this.handleUndo}
onUpdateName={this.props.onUpdateName}
@ -77,6 +78,7 @@ PaintEditor.propTypes = {
rotationCenterX: PropTypes.number,
rotationCenterY: PropTypes.number,
svg: PropTypes.string,
svgId: PropTypes.string,
undoSnapshot: PropTypes.func.isRequired,
undoState: PropTypes.shape({
stack: PropTypes.arrayOf(PropTypes.object).isRequired,

2
src/containers/paper-canvas.jsx
View file

@ -29,6 +29,7 @@ class PaperCanvas extends React.Component {
}
}
componentWillReceiveProps (newProps) {
if (this.props.svgId === newProps.svgId) return;
for (const layer of paper.project.layers) {
layer.removeChildren();
}
@ -108,6 +109,7 @@ PaperCanvas.propTypes = {
rotationCenterX: PropTypes.number,
rotationCenterY: PropTypes.number,
svg: PropTypes.string,
svgId: PropTypes.string,
undoSnapshot: PropTypes.func.isRequired
};
const mapDispatchToProps = dispatch => ({

1
src/playground/playground.jsx
View file

@ -49,6 +49,7 @@ class Playground extends React.Component {
return (
<PaintEditor
{...this.state}
svgId="meow"
onUpdateName={this.handleUpdateName}
onUpdateSvg={this.handleUpdateSvg}
/>