From b3dda0b9a7a2b2851c862509318f422009c41699 Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Thu, 7 Feb 2019 17:48:37 -0500 Subject: [PATCH 1/2] clarified country code step in adding new language --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d6ef1fb1..abf87637 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -26,7 +26,8 @@ There are two situations in which we create manual PRs to update translations: * [ ] Check if language is right-to-left. If so: * Add entry in `rtlLocales` -* [ ] Check if language needs a new locale (such as Brasilian Portuguese). If so: +* [ ] Check if the new language uses a country code + * Check [https://www.transifex.com/explore/languages](https://www.transifex.com/explore/languages); compare to the ISO code on the language's Wikipedia page. If they are different: * [ ] Edit `src/supported-locales.js`: * Add new entry to `localeMap`. Format is `'': ''` * [ ] Edit `.tx/config`: From 7b7e9435eb69b2293a5935231ba2f93e28bb8bb6 Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Mon, 11 Feb 2019 14:29:40 -0500 Subject: [PATCH 2/2] clarified country code issue --- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index abf87637..d3ac2976 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -27,11 +27,11 @@ There are two situations in which we create manual PRs to update translations: * Add entry in `rtlLocales` * [ ] Check if the new language uses a country code - * Check [https://www.transifex.com/explore/languages](https://www.transifex.com/explore/languages); compare to the ISO code on the language's Wikipedia page. If they are different: + * Check [https://www.transifex.com/explore/languages](https://www.transifex.com/explore/languages). If the language has a country code: * [ ] Edit `src/supported-locales.js`: - * Add new entry to `localeMap`. Format is `'': ''` + * Add new entry to `localeMap`. Format is `'': ''` * [ ] Edit `.tx/config`: - * Add to the `lang_map` list. Format is `:` + * Add to the `lang_map` list. Format is `:` * NOTE: we are moving away from using the `tx` cli; `.tx/config` will eventually be deprecated * [ ] Edit `src/index.js`: