From f96e4fb6e13873d06fd3840c1c0c991fd9e4a60a Mon Sep 17 00:00:00 2001 From: Ben Wheeler Date: Wed, 17 Jun 2020 11:24:02 -0400 Subject: [PATCH 1/2] updated checklist per issues we noticed in adding mongolian --- .github/PULL_REQUEST_TEMPLATE.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9e62a75b..4efeb9c7 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -36,7 +36,7 @@ There are two situations in which we create manual PRs to update translations: * NOTE: we are moving away from using the `tx` cli; `.tx/config` will eventually be deprecated * [ ] Edit `src/index.js`: - * [ ] Add 'import' line and export line + * [ ] Add 'import' line * [ ] Add entry in `localeData` array * [ ] Check if locale is in `react-intl` @@ -56,11 +56,12 @@ There are two situations in which we create manual PRs to update translations: * [ ] Bump minor version number in `package.json` -* [ ] **Update scratch-blocks dependency** - * scratch-blocks has its own translations. It will not pick up the new language unless the scratch-l10n dependency in `package.json` is updated to the new minor version. - * [ ] **Add language po files to scratchr2_translations** * manually update `scratchr2_translations/legacy` with `tx pull -l ` and check in changes * [ ] **Add language to scratchr2 settings** * manually update `settings/base.py` with the new language + +* [ ] **Update scratch-blocks dependency** + * [ ] in `package.json`, update the version of the scratch-l10n dependency to the version number you used above + * [ ] pull translations so that a new `Blockly.ScratchMsgs.locales[""]` is added to `msg/scratch_msgs.js` From a7781f39c361912f63f0ffca0809819a35d4e3ee Mon Sep 17 00:00:00 2001 From: Benjamin Wheeler Date: Wed, 17 Jun 2020 17:00:17 -0400 Subject: [PATCH 2/2] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: chrisgarrity --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4efeb9c7..eeb76c4e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -62,6 +62,7 @@ There are two situations in which we create manual PRs to update translations: * [ ] **Add language to scratchr2 settings** * manually update `settings/base.py` with the new language +#### After scratch-l10n update is published: * [ ] **Update scratch-blocks dependency** * [ ] in `package.json`, update the version of the scratch-l10n dependency to the version number you used above * [ ] pull translations so that a new `Blockly.ScratchMsgs.locales[""]` is added to `msg/scratch_msgs.js`