mirror of
https://github.com/scratchfoundation/scratch-l10n.git
synced 2024-12-22 05:32:34 -05:00
added pull request template, and note on where to find react-intl info
This commit is contained in:
parent
8ca0a67b2b
commit
4c9541b47d
2 changed files with 55 additions and 0 deletions
52
.github/PULL_REQUEST_TEMPLATE.md
vendored
Normal file
52
.github/PULL_REQUEST_TEMPLATE.md
vendored
Normal file
|
@ -0,0 +1,52 @@
|
|||
### Resolves
|
||||
|
||||
- Resolves #
|
||||
|
||||
### Proposed Changes
|
||||
|
||||
_Describe what this Pull Request does_
|
||||
|
||||
## Checklist for updating translations
|
||||
|
||||
There are two situations in which we create manual PRs to update translations:
|
||||
|
||||
1. We don't want to wait for Travis's automatic weekly update; or,
|
||||
2. We need to add a language that has become ready
|
||||
|
||||
### 1. Updating translations manually
|
||||
|
||||
* [ ] Pull translations from Transifex with `> npm run pull:editor`
|
||||
* [ ] Test the result with `> npm run test`
|
||||
* [ ] Confirm that you see changes to files like `editor/<resource>/<lang code>.json`
|
||||
|
||||
### Adding a language
|
||||
|
||||
* [ ] Edit `src/supported-locales.js`:
|
||||
* [ ] Add entry for the language in the `locales` const
|
||||
* [ ] Check if language is right-to-left. If so:
|
||||
* Add entry in `rtlLocales`
|
||||
|
||||
* [ ] Check if language needs a new locale (such as Brasilian Portuguese). If so:
|
||||
* [ ] Edit `.tx/config`:
|
||||
* Add to the `lang_map` list. Format is `<Transifex locale string/ISO standard>:<browser locale string>`
|
||||
* [ ] Edit `src/supported-locales.js`:
|
||||
* Add new entry to `localeMap`. Format is `'<browser locale string>': '<Transifex locale string/ISO standard>'`
|
||||
|
||||
* [ ] Edit `src/index.js`:
|
||||
* [ ] Add 'import' line and export line
|
||||
* [ ] Add entry in `localeData` array
|
||||
|
||||
* [ ] check if locale is in `react-intl`
|
||||
* Look in [https://unpkg.com/react-intl/locale-data/](https://unpkg.com/react-intl/locale-data/)
|
||||
* If not in `react-intl`:
|
||||
* [ ] Edit `src/supported-locales.js`:
|
||||
* In `customLocales`, add entry with parent set to a `react-intl` locale
|
||||
* [ ] Edit `src/index.js`:
|
||||
* In `localeData`, add entry for parent locale
|
||||
|
||||
* [ ] update translations per the "Updating translations" section above
|
||||
* [ ] Confirm that we see changes to:
|
||||
* [ ] `src/supported-locales.js`
|
||||
* [ ] `src/index.js`
|
||||
* [ ] `.tx/config` (if language needed a new locale)
|
||||
* [ ] Multiple files like `editor/<resource>/<lang code>.json`
|
|
@ -1,3 +1,6 @@
|
|||
// to find locale data in react-intl, go to:
|
||||
// https://unpkg.com/react-intl/locale-data/
|
||||
|
||||
import en from 'react-intl/locale-data/en';
|
||||
import am from 'react-intl/locale-data/am';
|
||||
import ar from 'react-intl/locale-data/ar';
|
||||
|
|
Loading…
Reference in a new issue