From 13c9a785d9f7132aa2a397c815986de53e7eb3ae Mon Sep 17 00:00:00 2001 From: chrisgarrity Date: Thu, 25 Apr 2019 17:16:58 -0400 Subject: [PATCH] Reference the other steps needed for adding a language Scratch-blocks, scratchr2 and scratchr2_translations all need manual updates when a language is added. Since l10n changes will usually be the starting point, add reminders for the others here. --- .github/PULL_REQUEST_TEMPLATE.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e4abc915..9e62a75b 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -56,5 +56,11 @@ There are two situations in which we create manual PRs to update translations: * [ ] Bump minor version number in `package.json` -* **Update scratch-blocks dependency** - * scratch-blocks has its own translations. It will not pick up the new language unless the scratch-l10n dependency in `package.json` is updated to the new minor version. +* [ ] **Update scratch-blocks dependency** + * scratch-blocks has its own translations. It will not pick up the new language unless the scratch-l10n dependency in `package.json` is updated to the new minor version. + +* [ ] **Add language po files to scratchr2_translations** + * manually update `scratchr2_translations/legacy` with `tx pull -l ` and check in changes + +* [ ] **Add language to scratchr2 settings** + * manually update `settings/base.py` with the new language