scratchfoundation/scratch-html5
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed evil evals

Browse source 
Filters now reset when the stop button is clicked.
This commit is contained in:
djdolphin 2013-11-03 07:10:45 -05:00
parent 64535641fc
commit c40c1b4027
3 changed files with 18 additions and 23 deletions
js/primitives
LooksPrims.js

6
js/primitives/LooksPrims.js
View file

@ -155,15 +155,15 @@ LooksPrims.prototype.primGoBack = function(b) {
LooksPrims.prototype.primChangeEffect = function(b) {
var s = interp.targetSprite();
var filter = interp.arg(b, 0);
var currentValue = eval("s." + filter + "FilterEffect");
eval("s." + filter + "FilterEffect = (currentValue + (interp.arg(b, 1)));");
var currentValue = s.filters[filter];
s.filters[filter] = currentValue + interp.arg(b, 1);
s.updateTransform();
}
LooksPrims.prototype.primSetEffect = function(b) {
var s = interp.targetSprite();
var filter = interp.arg(b, 0);
eval("s." + filter + "FilterEffect = (interp.arg(b, 1));");
s.filters[filter] = interp.arg(b, 1);
s.updateTransform();
}