Merge pull request from KManolov3/feature/uepr-40-desktop-feature-parity

fix: provide teamid to notarytool
This commit is contained in:
Kaloyan Manolov 2025-05-08 14:24:52 +03:00 committed by GitHub
commit 83c9423dac
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 3 deletions
.github/workflows
fastlane
scripts

View file

@ -28,6 +28,8 @@ jobs:
SCRATCH_SHOULD_SIGN: ${{ github.ref_name == 'develop' && matrix.os != 'windows-latest' }}
AC_USERNAME: ${{ (github.ref_name == 'develop' && secrets.AC_USERNAME) || '' }}
AC_PASSWORD: ${{ (github.ref_name == 'develop' && secrets.AC_PASSWORD) || '' }}
# Required for notarization on Mac
AC_TEAM_ID: ${{ secrets.AC_TEAM_ID || 'W7AR3WMP87' }}
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3
- uses: actions/setup-node@1a4442cacd436585916779262731d5b162bc6ec7 # v3

View file

@ -1,3 +1,3 @@
app_identifier "edu.mit.scratch.scratch-desktop" # The bundle identifier of your app
apple_id "bot-apple@scratch.mit.edu" # Your Apple email address
team_id "W7AR3WMP87"
app_identifier("edu.mit.scratch.scratch-desktop") # The bundle identifier of your app
apple_id("bot-apple@scratch.mit.edu") # Your Apple email address
team_id(ENV.fetch("AC_TEAM_ID"))

View file

@ -30,6 +30,7 @@ const notarizeMacBuild = async function (context) {
appPath: `${appOutDir}/${productFilename}.app`,
appleId,
appleIdPassword: process.env.AC_PASSWORD || `@keychain:${appleIdKeychainItem}`,
teamId: process.env.AC_TEAM_ID || '',
tool: 'notarytool'
});
};