scratchfoundation/scratch-desktop
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-desktop.git synced 2025-01-09 06:01:57 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix MAS file overwrite by deleting existing file

Browse source 
From the code comments:
If the file exists the browser will first download to a temp file then rename to the userChosenPath.
The MAS sandbox allows accessing userChosenPath but not the temp file, so overwriting fails on MAS.
Deleting the file first could be considered risky but works around the sandbox problem.
Security bookmarks might work to fix the problem but they're only supported by async showSaveDialog.
Since we need to use showSaveDialogSync (see WARNING below) this workaround might be the best option.
This commit is contained in:
Christopher Willis-Ford 2020-08-21 13:58:35 -07:00
parent a9cfad8df8
commit 75589099f1
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/main/index.js
View file

@ -237,6 +237,14 @@ const createMainWindow = () => {
}
const userChosenPath = dialog.showSaveDialogSync(window, options);
if (userChosenPath) {
// If the file exists the browser will first download to a temp file then rename to the userChosenPath.
// The MAS sandbox allows accessing userChosenPath but not the temp file, so overwriting fails on MAS.
// Deleting the file first could be considered risky but works around the sandbox problem.
// Security bookmarks might work to fix the problem but they're only supported by async showSaveDialog.
// Since we need to use showSaveDialogSync (see WARNING below) this workaround might be the best option.
if (fs.existsSync(userChosenPath)) {
fs.unlinkSync(userChosenPath);
}
// WARNING: `setSavePath` on this item is only valid during the `will-download` event. Calling the async
// version of `showSaveDialog` means the event will finish before we get here, so `setSavePath` will be
// ignored. For that reason we need to call `showSaveDialogSync` above.