Karishma Chadha
559b17c4ee
Fix importing cloud vars from xml.
2018-11-29 22:58:41 -05:00
Karishma Chadha
93bbd0b00f
Track cloud variable info and handle naming and renaming cloud variables.
2018-11-13 16:43:00 -05:00
Karishma Chadha
0fa3ef6e78
Fix RTL block comment positioning and RTL workspace comment rendering
2018-10-02 16:48:58 -04:00
Andrew Sliwinski
5b34893292
Revert "Throw Errors instead of using goog.asserts"
2018-08-22 15:29:43 -04:00
Rachel Fenichel
c88b1f8d2a
Throw Errors instead of using goog.asserts
2018-07-24 16:21:15 -07:00
Karishma Chadha
7d72017156
When opt_noId is specified to true, shadow ids should also be removed.
2018-07-23 11:29:01 -04:00
Karishma Chadha
b35102f8c7
Serialize and deserialize variable scope information when converting to/from XML
2018-07-06 13:04:25 -04:00
Karishma Chadha
ed05e7bf13
ScratchBlockComment constructor should handle NaN inputs.
2018-06-14 09:21:44 -04:00
Karishma Chadha
e8e1ee640e
Fix top comment export so that block comments are not duplicately serialized as workspace comments.
2018-06-08 16:17:06 -04:00
Karishma Chadha
2c2970df57
Code cleanup addressing PR comments
2018-06-06 18:45:32 -04:00
Karishma Chadha
058c68eebb
Cleaning up undo and redo of events some more (particularly undo deletion). Setting the size of a comment is separate from setting the visual comment bubble. E.g. minimizing a comment changes the bubble size but not the comment size. Separate this functionaltiy into two separate functions. Creating a comment should also take in stater text. Creating a comment for the first time does not also need to trigger an event for setting the comment text.
2018-06-06 15:29:03 -04:00
Karishma Chadha
3d3b8f3427
Final changes for comment events. Resizing and minimizing/maximizing changes are recorded in CommentChange event. Undo/Redo works for all events.
2018-06-01 17:22:10 -04:00
kchadha
e38969831e
Merge pull request #1544 from kchadha/comments
...
Scratch Block Comments
2018-05-30 19:31:06 -04:00
Karishma Chadha
f547cbff45
Fix comments.
2018-05-30 15:16:33 -04:00
Karishma Chadha
516ca3372b
Use ScratchBlockComment everywhere and break out comment to dom translation into a helper function.
2018-05-30 10:28:14 -04:00
Karishma Chadha
4afc8e5085
Scratch block comments.
2018-05-25 17:21:31 -04:00
Rachel Fenichel
af4060c75b
Add ordered option to getDescendants and all uses.
...
"
2018-05-16 12:51:41 -07:00
Rachel Fenichel
9773dbe6db
More work to pull in workspace comments
2018-05-11 17:18:19 -07:00
Rachel Fenichel
4836e55536
Break events.js into multiple files
2018-05-09 13:34:21 -07:00
Rachel Fenichel
49eca4eee0
More lint
2018-05-02 11:05:43 -07:00
Rachel Fenichel
f0b6e72888
Merge pull request #1479 from rachel-fenichel/feature/mark_things_protected
...
Lint that caused conflicts with Blockly; mark things protected
2018-04-30 14:51:03 -07:00
Rachel Fenichel
4fc5b6ac97
More small stuff from google, and allow unused vars with _names
2018-04-26 17:06:12 -07:00
Rachel Fenichel
1ddc189abc
Add referencesVariables function to fields
2018-04-25 15:21:55 -07:00
Karishma Chadha
78b2cd84dc
Cleanup of realizePotentialVar function.
2018-01-22 10:53:15 -05:00
Karishma Chadha
73f55ee9a8
Fixing issue where switching sprites was causing variable getter of a renamed variable to switch back to the old name.
2018-01-19 10:27:10 -05:00
Rachel Fenichel
7102012240
Pulling in final changes from upstream blockly/variables_by_id branch.
...
Includes commits 1fa27fa (01/12/18) through fa91c6b (01/16/18).
2018-01-18 15:03:46 -05:00
Karishma Chadha
d8a63f3aa4
Fixing issue where importing an SB2 project that uses the 'message1' default broadcast message wasn't wokring because of the way the realizePotentialVars function was written. The imported 'message1' broadcast message was conflicting with the one that is a potential variable in the flyout.
2018-01-18 15:03:46 -05:00
Karishma Chadha
2aabea010b
Fixing errors and making unit tests work.
2018-01-18 15:03:46 -05:00
Rachel Fenichel
855ec2665a
Pulling in the latest changes from google/blockly/variables_by_id branch,
...
starting with commit 6218750 (December 19, 2017) through commit 80b397f (January 10, 2018).
2018-01-18 15:03:46 -05:00
Karishma Chadha
87740cdea7
Fixing behavior where converting a potential variable into a real variable (e.g. dragging out a broadcast block out of the flyout with the default 'message1' option selected or creating a new message called 'message1' from the flyout) keeps the variable in both the potential variable map as well as the real variable map, so dropdown menus in the broadcast blocks from the flyout will display duplicate entries for the variable.
2018-01-18 15:03:46 -05:00
Karishma Chadha
af099d514b
Partially working status. Things that don't work: broadcast-messages (dragging out 'message1' block creates two 'message1' options in the flyout block dropdowns)... -- this problem has been partially addressed in a separate branch 'broadcast-message-flyout'; variables - largely don't work, having issues with toolbox not refreshing.
2018-01-18 15:03:46 -05:00
Karishma Chadha
5d42bedd3b
Fixing xml to block (and vice-versa) translation for variables.
2018-01-18 15:03:46 -05:00
Karishma Chadha
db44603362
Pulling in changes from blockly/variables_by_id.
2018-01-18 15:03:46 -05:00
Karishma Chadha
cc3a2426c0
Changing broadcast blocks to have input value fields, and field variable shadows. Flyout stuff needs to be fixed.
2017-12-21 21:11:15 -05:00
Karishma Chadha
f84e764951
Adding some TODO comments referencing existing issues also discussed in this PR.
2017-11-20 17:15:04 -05:00
Karishma Chadha
d9b5dc09ce
Changing === to ==
2017-11-20 17:01:42 -05:00
Karishma Chadha
cd5fe76811
Another comment clarification.
2017-11-17 13:59:27 -05:00
Karishma Chadha
9ddf8a79a9
Adding ability to create a new broadcast message using the dropdown option. Broadcast messages are now typed variables with the variable type as 'broadcast_msg'. Needed to do some extra work to translate variables from blocks to XML correctly because the default broadcast messages were getting added as new variables with the incorrect type upon trying to move any of the broadcast message related blocks from the toolbar into the workspace because it was trying to create a new variable with a different type than already existed. Currently, broadcast message names conflict with variable names, and I need to make it so that isn't so. Additionally, need to update the source block's message name after creation of a new message via the dropdown.
2017-11-16 11:45:59 -05:00
Paul Kaplan
807743d20f
Change variableType to variabletype in xml.
...
Scratch-blocks version of blockly pr #1422
2017-11-06 10:29:43 -05:00
picklesrus
b48b0dc67e
Add the new clearWorkspaceAndLoadFromXml to the set of globals so the compiler does not rename it. This should have been part of #1178 ( #1184 )
2017-10-26 11:16:45 -07:00
picklesrus
a54957c637
Add an xml utility to clear the workspace and then load xml into the dom. In it, use a new toolbox refresh mechanism that allows for batch updates. It mirrors the setResizesEnabled mechanism for managing batch updates to the workspace.
2017-10-24 14:33:53 -07:00
Paul Kaplan
97426e17b2
Merge pull request #1168 from picklesrus/develop-revert-bulk-update
...
Revert #1122 and changes made on top of it.
2017-10-23 10:24:44 -04:00
picklesrus
13e5c30e26
Revert #1122 and changes made on top of it. See discusson on #748 and #1145 . We will fix this a different way next week
2017-10-20 17:53:14 -07:00
Rachel Fenichel
cb058a69af
Add a serializable attribute to field, distinct from EDITABLE
2017-10-20 13:58:20 -07:00
Sam El-Husseini
c55824d619
Avoid IE and Edge re-rendering ( #1326 )
...
* Fix wrong width of field_dropdown with an image on Edge / IE
* Avoid re-rendering on IE and Edge by using getBBox().width to compute the text width on those browsers
2017-10-19 14:43:43 -04:00
Neil Fraser
a119cca83b
Compatibility for Closure Compiler. ( #1240 )
2017-10-19 11:47:04 -04:00
Rachel Fenichel
c838ca3a87
Add a bulkUpdate flag to avoid expensive operations (such as toolbox refresh) during workspace loading.
2017-10-09 12:04:59 -07:00
marisaleung
bf7f8bbaeb
Adding lists!
2017-07-25 15:03:40 -07:00
marisaleung
ffc1eb7682
Add VariableType checks.
2017-07-21 11:02:25 -07:00
Paul Kaplan
e1c4b8a5d2
Merge branch 'develop' into merge/06-22
2017-06-23 11:49:36 -04:00
