Commit graph

292 commits

Author SHA1 Message Date
Mathias Søholm
eb7dfe6867 Now using correct delete count to check if should show dialog 2019-08-13 13:56:44 +02:00
Karishma Chadha
93bbd0b00f Track cloud variable info and handle naming and renaming cloud variables. 2018-11-13 16:43:00 -05:00
Rachel Fenichel
1ad1d98e75 Remove unneeded logs () 2018-10-24 11:42:42 -04:00
Andrew Sliwinski
5b34893292
Revert "Throw Errors instead of using goog.asserts" 2018-08-22 15:29:43 -04:00
Rachel Fenichel
698af3fcbb
Merge pull request from rachel-fenichel/cleanup/throw_errors
Throw Errors instead of using goog.asserts
2018-08-16 11:03:59 -07:00
DD Liu
731ab04cb0
Merge pull request from towerofnix/shift-scroll-firefox
Make holding shift to scroll work on Firefox
2018-08-13 14:09:25 -04:00
DD
a1cb7801bc Add issue to todo and getter for isVisible on workspace 2018-08-08 20:32:22 -04:00
DD
4e6707bcee Only take keypresses when visible 2018-08-07 17:46:48 -04:00
Florrie
a3b102050d Make holding shift to scroll work on Firefox 2018-08-03 18:25:56 -03:00
Rachel Fenichel
c88b1f8d2a Throw Errors instead of using goog.asserts 2018-07-24 16:21:15 -07:00
Florrie
ce4204c2f2 Move line scroll multiplier to constants.js 2018-07-23 14:00:29 -03:00
Florrie
eb751cb91e Merge branch 'develop' of https://github.com/LLK/scratch-blocks into linescroll 2018-07-23 13:51:47 -03:00
Karishma Chadha
c23fe53344 Allow for local variables by passing in extra scope information (provided by the gui). This information is included in the varCreate event. Pass in a list of additional var names to check against when creating a variable (e.g. local var names from all sprites when checking for name conflicts to create a global var. 2018-07-03 14:01:49 -04:00
Paul Kaplan
88383d0998 Use the main workspaces stack glow filter for both flyout and toolbox
This fixes the stack glow filter not existing for both the "simple" and "category" modes of the workspace.
2018-06-01 10:18:42 -04:00
Rachel Fenichel
da93357d3f
Merge pull request from rachel-fenichel/ordered_children
Add ordered option to getDescendants and all uses.
2018-05-25 11:00:55 -07:00
Karishma Chadha
c33b1e35c3 Add the require for WorkspaceCommentSvg.rener 2018-05-21 11:35:31 -04:00
Rachel Fenichel
af4060c75b Add ordered option to getDescendants and all uses.
"
2018-05-16 12:51:41 -07:00
kchadha
e91e29c8d8
Merge pull request from rachel-fenichel/feature/merge_workspace_comments
Feature/merge workspace comments
2018-05-16 10:48:13 -04:00
Rachel Fenichel
91af54d85a Respond to review feedback 2018-05-15 17:02:35 -07:00
Ray Schamp
2868b2bbf2
Merge pull request from gnarf/delay-ctm-update
update ctm logic to fit with upstream change
2018-05-15 09:44:37 -04:00
Rachel Fenichel
9773dbe6db More work to pull in workspace comments 2018-05-11 17:18:19 -07:00
Rachel Fenichel
6a3692da01 Add the bubble dragger and ws comment basics 2018-05-11 16:35:31 -07:00
Rachel Fenichel
4836e55536 Break events.js into multiple files 2018-05-09 13:34:21 -07:00
Corey Frang
6257787397 update ctm logic to fit with upstream change 2018-05-07 15:38:17 -04:00
Mx Corey Frang
ddd356a48a
Mark CTM dirty instead of forcing a reflow/recalc ()
* Mark CTM dirty instead of forcing a reflow/recalc

* use false instead of DIRTY

* So "dirty"

* Blockly.DIRTY
2018-05-04 13:23:41 -04:00
Rachel Fenichel
fc0da3e070 All remaining lint in core 2018-05-02 15:32:28 -07:00
Rachel Fenichel
49eca4eee0 More lint 2018-05-02 11:05:43 -07:00
Rachel Fenichel
26b82223b4 Add a file for scratch-blocks-specific util functions 2018-04-30 15:55:31 -07:00
Rachel Fenichel
f0b6e72888
Merge pull request from rachel-fenichel/feature/mark_things_protected
Lint that caused conflicts with Blockly; mark things protected
2018-04-30 14:51:03 -07:00
Rachel Fenichel
6af7a60787 Add a function to center to workspace on a block 2018-04-26 17:12:17 -07:00
Rachel Fenichel
4fc5b6ac97 More small stuff from google, and allow unused vars with _names 2018-04-26 17:06:12 -07:00
Florrie
6081d996a4 Make scaling speed use line-mode multiplier 2018-03-31 22:17:07 -03:00
Florrie
8adbe95fb4 Tweak scroll speed
I'm only just realizing that this speed is probably dependent on the
system - but this is closer to how Chromium behaves on my Debian/Gnome
system.
2018-03-31 22:16:02 -03:00
Florrie
a23ef7ea95 Initial go at fixing scrolling on Firefox 2018-03-31 22:03:00 -03:00
Paul Kaplan
1815177a39 Move stack glow size into a settable parameter like the colors. 2018-03-20 11:07:01 -04:00
DD Liu
94f02f0b60 Avoid early return 2018-03-05 15:52:31 -05:00
DD Liu
28632cf5ab Use the parent SVG to get the blocks area. The parent SVG size doesnt include all blocks. 2018-03-05 14:34:41 -05:00
DD
4659479cfa Add private 2018-02-21 18:31:34 -05:00
DD
92023c45ce Code review 2018-02-16 17:37:49 -05:00
DD
534eb28e83 Fix comments 2018-02-15 18:13:06 -05:00
DD
43780723e1 Send block drag events 2018-02-15 18:13:06 -05:00
Rachel Fenichel
7102012240 Pulling in final changes from upstream blockly/variables_by_id branch.
Includes commits 1fa27fa (01/12/18) through fa91c6b (01/16/18).
2018-01-18 15:03:46 -05:00
Karishma Chadha
06316d4456 Fixing issue where toolbox wasn't refreshing when adding a list with the same name as a variable. 2018-01-18 15:03:46 -05:00
Karishma Chadha
62b85298dc Temporary fix for delete variable option not working from context menu of field_variable_getter from the flyout. This will be fixed upstream. 2018-01-18 15:03:46 -05:00
Karishma Chadha
8447633bf0 More minor code cleanup. 2017-12-22 10:18:19 -05:00
Karishma Chadha
9fbb924e1c Fixing flyout behavior for broadcast blocks (e.g. ) and ensuring that the message1 shows in the dropdown by defualt. 'message1' gets created as a variable on the flyout's target workspace upon dropdownCreate. 2017-12-21 21:11:15 -05:00
picklesrus
a54957c637 Add an xml utility to clear the workspace and then load xml into the dom. In it, use a new toolbox refresh mechanism that allows for batch updates. It mirrors the setResizesEnabled mechanism for managing batch updates to the workspace. 2017-10-24 14:33:53 -07:00
picklesrus
2996c86c53 Do not refresh the toolbox when a new variable is created on the work… ()
* Do not refresh the toolbox when a new variable is created on the workspace but it already exists in the variable map.  This gets rid of some calls to Toolbox.refreshSelection. e.g. when you drag a variable block out of the toolbox, we were refreshing the toolbox.  It will also help with xml loading for workspaces using multiple of the same variable reporter.  More needs to be done to solve , but this helps a little.

* Fix typo
2017-10-24 12:40:22 -07:00
picklesrus
13e5c30e26 Revert and changes made on top of it. See discusson on and . We will fix this a different way next week 2017-10-20 17:53:14 -07:00
Paul Kaplan
8f5156c72c Fix lost newline 2017-10-19 17:10:42 -04:00