Paul Kaplan
|
ebc2e9dab7
|
Merge pull request #1975 from paulkaplan/better-touch-comments
More touchable comments, and a few RTL bugfixes
|
2019-07-31 09:56:52 -04:00 |
|
Paul Kaplan
|
fd40039dc8
|
Merge pull request #1971 from paulkaplan/comment-placeholders
Use placeholders instead of default text for comments, fix focusing
|
2019-07-31 09:38:05 -04:00 |
|
Paul Kaplan
|
9862429ba7
|
Fix text spilling out of minimized workspace comments in RTL
|
2019-07-30 12:21:23 -04:00 |
|
Paul Kaplan
|
2bf63bacc5
|
Change resize handle to add a larger hitbox to make touch interactions easier
|
2019-07-30 11:54:35 -04:00 |
|
Paul Kaplan
|
ef9b4cc2b8
|
Resize minimize/delete handle icons so they take up the entire topbar height. This makes them much easier to touch
|
2019-07-30 11:53:33 -04:00 |
|
Paul Kaplan
|
8d4e38786e
|
Fix RTL bug where resize handle was positioned incorrectly
|
2019-07-30 11:52:38 -04:00 |
|
Paul Kaplan
|
7e83e50aa0
|
Fix a layout bug in RTL with workspace comment delete icon, was accidentally giving the correct value, but changing sizes revealed it was doing it wrong
|
2019-07-30 11:50:32 -04:00 |
|
Paul Kaplan
|
c72e6934b4
|
Use placeholders instead of a default value for comments
|
2019-07-29 14:40:57 -04:00 |
|
Paul Kaplan
|
469fe8b1e0
|
Fix error when deleting comments caused by trying to blur removed node
|
2019-07-29 13:18:28 -04:00 |
|
Paul Kaplan
|
b900bd2742
|
Stop propagation for textarea clicks to make sure preventDefault is not called by workspace event listeners
|
2019-07-29 13:18:01 -04:00 |
|
Paul Kaplan
|
3a992ac697
|
Mark delete/resize events as noCaptureIdentifier to stop workspace freezing
|
2019-07-29 13:12:54 -04:00 |
|
Paul Kaplan
|
d95476ffa8
|
Move workspace comment click target rect to only cover the textarea
|
2019-07-29 13:10:42 -04:00 |
|
picklesrus
|
38f2d8e1b5
|
remove stray newline
|
2019-07-24 16:05:35 -04:00 |
|
picklesrus
|
90f90aa47b
|
Move call to focus element outside of the the setTimeout. iOS is picky about what things you can do outside of a direct user action and I think focus might be one of them. With this change comments are now editable on iOS.
|
2019-07-24 15:56:12 -04:00 |
|
Ashwin Ramaswami
|
79b9cf6163
|
Comment formatting improvements
|
2018-12-19 08:44:20 -05:00 |
|
Karishma Chadha
|
0fa3ef6e78
|
Fix RTL block comment positioning and RTL workspace comment rendering
|
2018-10-02 16:48:58 -04:00 |
|
Karishma Chadha
|
66a844502a
|
Add a character limit to the comment textareas.
|
2018-06-15 17:32:19 -04:00 |
|
Karishma Chadha
|
0a453c623a
|
Fix issues with scrolling workspace just after resizing a comment.
|
2018-06-15 12:59:25 -04:00 |
|
Karishma Chadha
|
017f536509
|
Remove explicit z-index from comment foreign body.
|
2018-06-14 17:26:00 -04:00 |
|
Karishma Chadha
|
5ea7369c35
|
Add a piece of state to keep track of whether the same icon that had a mouse up event also first had a mouse down event on it.
|
2018-06-12 14:56:21 -04:00 |
|
Karishma Chadha
|
4ea6cd80fd
|
Change top bar label without removing and then recreating/readding a text node.
|
2018-06-12 14:56:21 -04:00 |
|
Karishma Chadha
|
6f33ef2c2a
|
If body should be in a block on a new line.
|
2018-06-12 14:56:21 -04:00 |
|
Karishma Chadha
|
7f93185b38
|
Add comments to differentiate between setMinimized and setRenderedMinimizeState
|
2018-06-12 14:56:21 -04:00 |
|
Karishma Chadha
|
18c512fce2
|
Add comment target back so that workspace comments can be dragged from center of comment as well as top bar.
|
2018-06-12 14:50:45 -04:00 |
|
Karishma Chadha
|
42a6637579
|
fix constant ordering
|
2018-06-12 14:50:45 -04:00 |
|
Karishma Chadha
|
3a31481af9
|
Workspace comment render updates (to match block comments), and new minimize state and functionality.
|
2018-06-12 14:50:45 -04:00 |
|
Karishma Chadha
|
2c2970df57
|
Code cleanup addressing PR comments
|
2018-06-06 18:45:32 -04:00 |
|
Karishma Chadha
|
21802e5570
|
Cleanup comment events to reduce code duplication. Fix some issues with undo/redo not emitting events.
|
2018-06-05 14:47:37 -04:00 |
|
Karishma Chadha
|
acb6f17119
|
Converge some workspace comment and block comment functions.
|
2018-06-01 21:19:33 -04:00 |
|
Karishma Chadha
|
3d3b8f3427
|
Final changes for comment events. Resizing and minimizing/maximizing changes are recorded in CommentChange event. Undo/Redo works for all events.
|
2018-06-01 17:22:10 -04:00 |
|
Rachel Fenichel
|
91af54d85a
|
Respond to review feedback
|
2018-05-15 17:02:35 -07:00 |
|
Rachel Fenichel
|
6a3692da01
|
Add the bubble dragger and ws comment basics
|
2018-05-11 16:35:31 -07:00 |
|