Commit graph

93 commits

Author SHA1 Message Date
Ivan Wang
73e20573df Fix allUsedVariables not returning non-predefined variables 2017-03-20 16:10:10 -07:00
Rachel Fenichel
c9182b97fa Add variable getter field 2017-02-22 13:49:39 -08:00
Rachel Fenichel
57c3666198 Feature/merge feb 2017 ()
* Revert "Rebuild nov 3 16"

* Move injected css to start of head

* simplification

* lint

* Remove copy/paste buttons.

* Localisation updates from https://translatewiki.net.

* Don't split dropdown text if there is an image.

* Unblock push to master.

* Revert "Revert "Rebuild nov 3 16""

This reverts commit c8ca24a000.

* rebuild

* Remove ifelse block and messages'

* Remove obsolete Gecko image hack.  Apparently this has been fixed in Gecko.

* Add correct focus behavior for the modal. Update boundary sounds.

* Disallow clicks on disabled buttons.

* add back metadata tag to qqq

* revert qqq.json

* Improve performance of block dragging.  This is a backport of the blo… ()

Improve performance of block dragging.  This is a backport of the block drag surface from scratch-blocks.  At the beginning of a block drag, blocks get moved to a drag surface which then translates using translate3d to avoid repainting the entire svg on every mouse move.  At the end of the drag, the blocks are dropped back in the svg in their new position.

* API-breaking cleanup.  But doubtful anyone will be affected. ()

* Make add/removeClass return whether they did anything.
* Move more functions onto utils.
* Move bind functions to Blockly.
* Routine recompile.

* String reference in JSON string messages ()

 * Adds message references to message string interpolation, in the form of %{BKY_STRING}.
 * Re-adding CONTROLS_IFELSE block using the new syntax, referencing to CONTROL_IF equivalents.

* Fix compiler errors.

* Break the sidebar out into its own individual component.

* Hide notification messages after a short time interval.

* Fix selection border on blocks that have been highlighted.

* controls_ifelse: Remove right-align. Remove Boolean check on statements. ()

* Move away from using a common modal service, since the block options and the toolbox modals are going to end up behaving fairly differently.

* Fix conflict between 'utils' and 'image dropdown' merges.

* Add a contextual modal for the toolbox.

* Fix some bugs arising in the toolbox modal for the no-categories case.

* Allow attaching blocks to a marked spot from the toolbox modal. This is the last prerequisite for removal of the existing on-screen toolbox.

* Delete the on-screen toolbox.

* Add warning sounds when the user reaches a boundary of the workspace.

* Stop some blocks from throwing errors in headless workspaces.

* Lint

* Fix speling.

* Fix broken highlighting when highlighted block is deleted.  Issue 752.

* When the workspace is empty, make it easy for the user to add a new group of blocks to it.

* Handle the finer points for setting focus correctly after deleting blocks from the workspace.

* When user edits text in a field, set text, not value.

Existing text-editable fields don’t care (dropdown care, but are not
text-editable).  But a note picker needs to set its value to 60 if text
is set to ‘C4’.

* Set the text not the value when closing a text editor.

Also rename variables for clarity.

* Localisation updates from https://translatewiki.net.

* Streamline the logic for block selection callbacks in the toolbox modal.

* Do not show disabled actions in the block options modal.

* Set focus correctly when toolbox modal is dismissed.

* Add information regarding target screen reader and browser.

* Rebuild Blockly.

* Remove unavailable blocks from toolbox modal. Hide unnecessary category name in a toolbox without categories.

* Do some refactoring and tidy-up. Pull some hardcoded strings out for i18n purposes; remove unused strings.

* Update config options for sidebar buttons.

* Minor refactoring. Remove unused dependencies.

* Improve styling of sidebar buttons.

* Remove clipboard functionality.

* Refactor and simplify marked spot logic.

* Change dropdowns to select fields instead of lists of buttons.

* Add ability to specify a css class for labels and buttons

* Don't make labels clickable

* console.log -> console.warn

* change 'class' to 'web-style'

* createSvgElement is now in utils.  fix two calls.

* Improve comments.

* lint

* fix missing semicolon

* When adding a new block group from the toolbox modal, only show blocks with no output connections.

* Clean up the sidebar file and remove unneeded code.

* Remove some functions from utilsService and consolidate code in workspace-tree.component.js.

* Standardize indentation.

* Remove premature focus on buttons in modal dialogs, since this prevents readout of the dialog text.

* Localisation updates from https://translatewiki.net.

* Don't get Toolbox element unless needed.

* Associate flyout button callbacks directly with workspaces

* Add colour block to the block factory base block initial state

* Start getting helpurl and tooltip in

* Generate helpURL and tooltip for Javascript block definition

* Use Tab keys instead of arrow keys for dialog boxes. Set role=alertdialog and read out the header/text automatically. Ensure that Esc key actually closes dialogs and that all keystrokes are captured.

* Add an aria-describedby to the 'create new block group...' button in the workspace to give more context.

* Fix issue with aria-liveregion not speaking. Allow sufficient time for alert noise to play before speaking the notification.

* Make zoom speed independent of event granularity

Before, touchpads would give "smoother" scrolling by delivering lots of
mousewheel events with small distance changes. Because the code only
looked at the sign of deltaY, ten 5px scrolls would zoom 10x more than
one 50px scroll.

This change makes zooming with a touchpad more like zooming with a
mousewheel. On my laptop, a full-scale zoom (fully out to fully in) was
about a 5mm finger movement before, and is now about 3cm.

Fixes .

* Split the scrollbar and flyout out into their own SVG elements. They ()

* Split the scrollbar and flyout out into their own SVG elements. They
are siblings of the workpsace SVG.  This paves the way to make performance
improvements to workspace dragging.

* remove overflow-y on the block exporter labels so scroll bars do not show upin firefox.  Also fix up the styles on the labels so that they display better in firefox. ()

* Fix  by adjusting the regex to not have \.  Still not 100% sure w… ()

* Fix  by adjusting the regex to not have \.  Still not 100% sure why that was there.
Also replaces bad names on input.  There are probably more invalid names but this is
a start.

* update generator comments

* Move the call to disable resize before placeNewBlock so that it is of… ()

* Move the call to disable resize before placeNewBlock so that it is off when workspace resizeContents
gets triggered by placeNewBlock.  This fixes a bug in rtl mode where the workspace was being resized
between when the block was added to the workspace and when it was moved to the proper location.

* Disable workspace resizing while loading the flyout from XML

* Localisation updates from https://translatewiki.net.

* Add a workspace drag surface that blocks and bubble get moved to duri… ()

* Add a workspace drag surface that blocks and bubble get moved to during a workspace drag.
The surface is translated using translate3d instead of svg's translate attribute so that
the browser does not have to repaint the entire workspace on every mouse move.
This is very similar to the block drag surface.

* Address code review comments

* add back hasClass_ utility removed in  and stop using contains since it is not supported in IE

* Fixes  by checking if getComputedStyle is null in is3dSupported.  We do not cache the value in this case and try again later. is3dSupported is only called while users are interacting with blockly which they cannot do while hidden so the performance implications of running the check again are minimal. ()

* Localisation updates from https://translatewiki.net.

* Change the Python codegen for string quoting to match the behaviour of `repr` on a string in CPython.

* Localisation updates from https://translatewiki.net.

* Add an `allInputsConnected` method to `Block` and `Workspace` to test whether all trees in the block forest have their inputs filled. An optional argument controls whether or not shadow blocks are counted as being filled. Recommitting changes off `develop` instead of `master` as per discussion in PR .

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Use the drag surface when scrolling using the scrollbars.  ()

* End event groups when you finish editing a field

* Fix  and make the workspace grid drag along with the workspace. ()

There was some IE specific code that also applies to Edge so just updated
a conditional to include Edge.

* Now that text input's setText skips setValue, it needs to explicitly create a change event

* Check if the text has changed before firing an event

* Init procedure blocks with empty name, and set default name in xml in Blockly.Procedures.flyoutCategory

* Routine rebuild

* Move createDom call into the constructor of block drag surface. ()

* Make cursor stay as a closed hand when dragging blocks around in the drag surface. Do this by applying the same style to text elements in the drag surface that we do in the main svg. ()

* Don't connect to blocks under the flyout.

* recompile again. ()

* Fix german translation

* Fix german translation of 'delete x blocks'

* Adding unit tests for ifelse block.

* Improvements to the generator test framework.

* <field>, <value> reorder due to load/save.

* Use the npm closure library instead of the same library installed at a parallel directory

* Fix undo/redo for FieldCheckbox

Thanks to PR  by ademenev

* PR : Adding support for string table lookups in dropdown field labels

Adding support for string table lookups in dropdown field labels specified in JSON.

Adds Blockly.utils.replaceMessageReferences() method to handle string replacement without interpolation tokens.  Effectively uses the same old code, now moved into tokenizeInterpolation_(), which takes a parseInterpolationTokens option.

Replaces the direct JavaScript references (not pure JSON, and thus not portable).

Demonstrating this behavior in the logic_boolean dropdown.

* Integrating qqq.json changes into messages.json. ()

From commits b77f8cbebc and 4ecdedec9f

* Naming changes in mirror demo

* Adding support for untranslated messages. ()

This will be used to define constants accessible in JSON block definitions. Messages with descriptions that include `{{Notranslate}}` will not be included in the translation files sent to TranslateWiki. Instead, they are written to `msg/json/constants.json`, and later merged back into the `.js` files, similar to synonyms.

Template details: https://translatewiki.net/wiki/Template:Notranslate

* JSON support for message lookup in colour, tooltip, and help URL. ()

String replacement for the colour, tooltip text and help URL attributes of JSON defined blocks.
Demonstrated in logic_boolean.

* Fixes as per code review on PR.

* Reduce number of Closure files in App Engine upload.

* Python false is False.  Issue .

* Replace 'const' with 'var'.

This unbreaks IE10 and advanced compiled apps such as Blockly Games.

* Fix bug in audioService where attached event callbacks were not being cleared properly.

* Rename workspace-tree to workspace-block.

* Minor refactoring of the modal code (add comments, guard against invalid keystrokes, etc.).

* FieldNumber & FieldAngle: Default value "0" ()

FieldNumber and FieldAngle previously accepted "undefined" as values, if not defined in JSON. This catches these and uses "0" for any NaN value.  The constructor value parameter is now optional. Includes tests.

* Remove unnecessary check when attaching a new block to a marked connection.

* Remove debug info.

* Refactor and simplify field-segment.component.js.

* Replace single quotes with double. ()

Fixes commits in .

* Adding extensions for JSON support of dynamic blocks. ()

Adding support for extensions, functions that can assist with loading blocks, much like init functions, but that can be referenced from JSON definitions. This allows JSON definitions to define dynamic blocks such as onchange handlers and mutators.

Rewrote math_number as an example pure JSON block.

* Add ability to add a class to a scrollbar so that different types of … ()

* Add ability to add a class to a scrollbar so that different types of scrollbars can
be distinguished from each other. You used to be able to do this by looking at the parent
element but now all the scrollbars are siblings in the dom.

Also, use this new class to fix  so that layering of the flyout and workspace scrollbars
are done correctly.

* JSON definitions for colour blocks ()

Replaces old colour block definitions with a Blockly.defineBlocksWithJsonArray(..) call. Generator unit tests continue to load and pass, signifying compatibility with prior block definitions.

Replaces extension 'math_number_tooltip' with the reusable 'parent_tooltip_when_inline' extension, also used by colour_picker. Includes tests.

* Rewrite tree.service.js.

- Remove unnecessary code and functions.
- Add documentation where needed.
- Fix a bug arising when a block on the workspace is attached to an existing link.

* Use setValue in fieldTextInput so that procedure renaming works

* Further cleanup and removal of unnecessary functions. Pull some strings out for i18n.

* Use bindEvent_ instead of bindEventWithChecks_ for longStop

* Clean up workspace.component.js. When moving a block from one place to another, move all blocks after it too, and adjust the active descs accordingly.

* Unit tests for JSON block definitions (just the start) ()

 * Beginnings of a JSON block definition unit test set.
 * Dispose of unit test workspaces and blocks in finally blocks.
 * Clarify JSON error message by echoing arg notation.

* New blocks text_count, text_replace, and text_reverse ()

Includes generators for all languages and units tests on those generators.

* Fixing combo boxes getting out-of-sync with NVDA.

Combo boxes need to be special cased like text input. Also, Escape is
a reserved button in NVDA, so I added Enter as a way to "submit and
move up a level" in addition to escape, so these boxes can be edited
while NVDA is on.

* Add a block to reverse a list ()

* Porting math.js blocks to JSON ()

Moving all `math.js` definitions into a single JSON array, complete with i18n syntax for all messages, dropdowns, and tooltips.

Adding Blockly.Extensions.buildTooltipForDropdown(..) to facilitate the creation and error-checking of tooltips that update based on the value of a dropdown.

Now warn on raw string in JSON 'extensions'.

* Fixing JSON support for images in dropdowns. Adding tests. ()

Fixes .

* Update README.md

Add a link to our forum.

* Correcting math_change color

* Enable custom flyout categories.

* Add some safety

* Update the set of reserved words in Python to reflect the current state of Python (2.7 and 3.6). ()

* .getOptions_() to .getOptions() ()

Fixes .

* Blockly.Extensions.buildTooltipForDropdown(..): Deferred validation. ()

Defer tooltip message string check until after load, when all Blockly.Msg should be loaded.
Avoids validation in headless mode, due to lack of document.readyState.

* annotation updates

* jsdoc corrections ()

* Remove use of Array.prototype.includes which is not implemented in IE or Edge < 14. Fixes .

* Attempt to work around the IE/Edge bug where `getComputedTextLength()` throws an exception when the SVG node is not visible. This workaround forces a re-render, which in turn, forces a re-calculation of the node width once a block is inserted into the workspace SVG. This workaround is only executed on IE and Edge. See https://groups.google.com/forum/#!topic/blockly/T8IR4t4xAIY for the initial discussion of this issue.

* Change CSS transforms to work with older browsers ()

* Change the setting of the CSS transform properties on SVG nodes to set both the unprefixed version and the `-webkit-` prefixed version so that Blockly correctly renders in order browsers, such as Safari < 9 and iOS Safari < 9.2. For discussion of this issue, see https://groups.google.com/forum/#!topic/blockly/o3pERaRQhSg

* Correct the separation between the CSS transform property and the rest of the CSS that was in the variable misleadingly called "transform".

* Don't try to get block position in a headless workspace

* Stop bumping neighbours in headless blockly

* Place context menu correctly on touch

* Clear all active desc ids when the 'Erase Workspace' button is pressed.

* Fix a bug where splicing a block between two linked blocks disconnects the group and messes up the focus.

* Deleting a top-level block does not cause blocks after it to be deleted. Properly handle the active desc for this case.

* Use the empty field placeholder for dropdowns that do not have a value selected.

* Bugfix for . I incorrectly converted one CSS transform setting to use the cross-browser setting function in 40a063763c74b3f712c3057565966c25d5cfdb10. ()

* Adding @namespace annotations for JSDoc. ()

* Fix typo causing TypeError ()

* Pinning the angular2 dependency, and including licenses. ()

* Add skeleton for tests on rendered workspaces

* Fix some lint errors

* Correct changedState in setWarningText() ()

When clearing warnings on blocks with IDs, the changedState variable should be true if the text changed. This will trigger the block being reshaped and remove the space for the notification icon (this.bumpNeighbours_).

* Adds Block.prototype.mixin() and Blockly.Extensions.registerMixin(). ()

Adds Block.prototype.mixin() and Blockly.Extensions.registerMixin().
This adds support for a common use pattern in extensions, and adds
error checking to avoid future incompatibilities.

* Porting Logic blocks to JSON ()

Extensions, mixins, mutators and constants now grouped under the new namespace Blockly.Constants.Logic.

* Improving errors/warnings with Block.toDevString() and Connection.toString(). ()

* Add isEditable to field, and add tests

* Separate tests

* Blockly.Constants.Math and Blockly.Constants.Colour extension constants ()

Also, correcting quotes in logic.js.

* Correction to logic_ternary type check ()

* Porting Loop blocks to JSON ()

 * Improved documentation on `Blockly.Extensions.buildTooltipForDropdown`
 * Replaced incorrect uses of `@mixes` JSDoc annotation (on mixin extensions) with `@augments Blockly.Block`.
 * Added Blockly.Extensions.buildTooltipWithFieldValue() extension helper.

* Workspace isDraggable

* JSONify simple list blocks

* JSONify variable blocks

* Initial text block, with a mixin to generate quote image fields. ()

Text block now uses the extension "text_quotes", supported by Blockly.Constants.Text.QUOTE_IMAGE_MIXIN.quoteField_(fieldName), so that each platform can use the best platform appropriate image (size, density, etc.) for the quotes.

* Add no-op stub .neighbors() for headless Connection.

* Adding tests for logic_ternary block in a new jsunit test framework.

* Correcting output of the logic_null block.

* extension controls_if => controls_if_mutator.

* Renamed extension function constant, and moved variables into the mixin.

* Dereference string table references when loading variable fields from JSON.

* Moving FieldImage string dereferencing back into Block.interpolate_() (part of jsonInit()). This sets a clear boundary of where dereferencing should happen.
Towards this, I've added message dereferencing for other field types here, as well.  I've used a pattern of field-type specific helper functions.

* Addressing comments.

* .utils.replaceMessageReferences(..) now gracefully returns non-string arguments.

* Fix a few small errors and rebuild

* Call dynamic toolbox generators correctly

* cleanup

* Fix unit tests, and delete a few that relied on completely undefined behaviour

* Fix RTL text inputs

* eslintignore more tests

* Fix insertion marker highlighting, I think

* Make getFlyout public
2017-02-21 15:09:23 -05:00
Andrew Sliwinski
be9d5fefed Merge from Upstream Blockly ()
* WIP merge from upstream google/blockly

* fixing some merging bugs. Getting the drag surface to work, updating some function calls, etc.

* make the trash can lid animate again and fix the cursor to show an x when things will be removed.

* Fix text rendering logic in fields

* Hand apply some more changes from blockly flyout.js to flyout_base.js.

Also revert 08efd1381c
in scratch-blocks since it breaks variables and there is more work fenichel is planning
to do here.

* Fix drop-down field rendering

* Resolve issue with text input field widths on init

* Remove unused blockly (built) files

* Remove unused language files

* Resolve lint issues and rebuild

* Add blockly build targets to cleanup script

* Return 0 if 'this.arrow_' does not exist in a dropdown field

* Remove unused / irrelevant comments
2017-02-02 14:17:43 -05:00
Rachel Fenichel
41fc324aee lint 2016-11-02 13:56:27 -07:00
Rachel Fenichel
844b7771e2 Merge branch 'develop' of https://github.com/google/blockly into feature/merge_nov_1 2016-11-01 18:00:26 -07:00
Rachel Fenichel
703bd96f7e Allow creation of buttons with developer-designated callbacks 2016-10-31 14:24:00 -07:00
Andrew n marshall
8f3b4bcb5e Replaces calls to window.alert(), window.confirm(), and window.prompt() with Blockly.alert(), Blockly.confirm(), and Blockly.prompt(). These are designed to allow app developers to replace the dialogs with versions that match their own open app, possibly avoiding modal browser dialogs. They each take a callback, so the developer has the opportunity to implement non-modal behavior. 2016-10-20 16:30:40 -07:00
Tim Mickel
d74e6652ac Allow text in "set var"; default "change var" = 1 () 2016-09-27 14:22:46 -04:00
Rachel Fenichel
a979a422e4 Merge branch 'develop' of https://github.com/google/blockly into merge_sept_01 2016-09-01 16:52:08 -07:00
Rachel Fenichel
d2ce081dc4 Move functions for updating variables on a workspace into workspace.js, and some lint 2016-08-17 16:07:50 -07:00
Rachel Fenichel
19722e2350 Use a Blockly.Msg for button text 2016-08-16 16:53:53 -07:00
Rachel Fenichel
4b5d4d4c26 Merge branch 'feature/variable_management' of https://github.com/google/blockly into feature/variable_management 2016-08-12 15:52:48 -07:00
Rachel Fenichel
775e298c2c Disallow deleting variables that are used in the definition of a function 2016-08-11 17:10:15 -07:00
Rachel Fenichel
cdbfce87de Make disposeUses private 2016-08-09 11:30:32 -07:00
Rachel Fenichel
bf6220cb42 Ask user for confirmation when deleting multiple uses of a variable. 2016-08-09 10:45:26 -07:00
Rachel Fenichel
6d37ebf6b1 Stop i from showing up everywhere 2016-07-13 16:28:41 -07:00
Rachel Fenichel
18be9d1de8 Merge branch 'feature/variable_management' of https://github.com/google/blockly into feature/variable_management 2016-07-13 14:36:35 -07:00
Rachel Fenichel
75e06de477 Use instanceof to distinguish between blocks and workspaces. 2016-07-13 12:50:44 -07:00
Monica Kozbial
2b191e897e Adding indexing settings, tests and fixing bugs ()
* Add indexing setting for JavaScript Generation

Adding setting to allow for switching between zero and one based indexing for Blockly Blocks such that the generated code will use this flag to determine whether one based or zero based indexing should be used. One based indexing is enabled by default.

* Updating js lists to do zero and one based index

Updated generated JavaScript to change depending on whether one based indexing is enabled or not.

* Updating js text to do zero and one based index

Change so that JavaScript generated for text blocks either assumes blocks use zero or one based index based on setting.

* Start of python indexing

Start of work on allowing one and zero indexing for generated python for lists.

* Fixing bug and lint fixed

Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing

* Converting from if to switch statements

Comverting if statements to switch statements when appropriate and adding spacing.

* Modified sublist JavaScript generation

Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).

* Stripping unecessary ids

Removing ids from xml file.

* Localisation updates from https://translatewiki.net.

* Fix typo in flyout.js ()

* Fix typo in flyout.js ()

* Localisation updates from https://translatewiki.net.

* Add indexing setting for JavaScript Generation

Adding setting to allow for switching between zero and one based indexing for Blockly Blocks such that the generated code will use this flag to determine whether one based or zero based indexing should be used. One based indexing is enabled by default.

* Updating js lists to do zero and one based index

Updated generated JavaScript to change depending on whether one based indexing is enabled or not.

* Updating js text to do zero and one based index

Change so that JavaScript generated for text blocks either assumes blocks use zero or one based index based on setting.

* Fixing bug and lint fixed

Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing

* Converting from if to switch statements

Comverting if statements to switch statements when appropriate and adding spacing.

* Modified sublist JavaScript generation

Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).

* Stripping unecessary ids

Removing ids from xml file.

* Updating generator test

Modifying sublist test and re-formatting spacing between blocks.

* Updating js lists to do zero and one based index

Updated generated JavaScript to change depending on whether one based indexing is enabled or not.

* Updating js text to do zero and one based index

Change so that JavaScript generated for text blocks either assumes blocks use zero or one based index based on setting.

* Fixing bug and lint fixed

Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing

* Converting from if to switch statements

Comverting if statements to switch statements when appropriate and adding spacing.

* Modified sublist JavaScript generation

Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).

* Stripping unecessary ids

Removing ids from xml file.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Updating js lists to do zero and one based index

Updated generated JavaScript to change depending on whether one based indexing is enabled or not.

* Fixing bug and lint fixed

Fixing bug caused by not setting the return of concat when concatenating lines for sublist and substring functions. Also renamed these functions to be getSubsequece. Fixed lint errors with spacing

* Modified sublist JavaScript generation

Added case so that helper function is not generated if not necessary. Helper function is not generated if list length is not needed or if list is a simple block (such as a variable, as oppossed to a function call or list create).

* Stripping unecessary ids

Removing ids from xml file.

* Updating generator test

Modifying sublist test and re-formatting spacing between blocks.

* Adding tests for indexing and extra cases

Adding tests for indexing with custom block to adjust number based on what indexing is being generated.

* Adding tests and renaming tests

Adding tests for sublist and renaming tests.

* Fixes for order for sublists

Fixes so that parenthesis are generated properly for index for sublist

* Cleaning up test generated code

Changing order returned for unit test adjust index function to generate less unecessary parenthesis.

* Adding tests for order

Adding tests for order, relevant for methods that use index from start (because 1 is added)

* Fixing JS order for getIndex and setIndex

Changing to the correct order type when calling valueToCode in JS generation for getIndex and setIndex.

* Fixed unittest adjustIndex

Fixed uninttest adjustindex to also check whether the ONE_BASED_INDEXING variable has been defined to ensure proper behaviour.

* Fixing lint and formatting for JS/lists

Making line fixes and changing an if/elseif to case statement.

* Tests added to include case for bug found

Added tests with sublist combinations of different where's for the two indices after bug for this found in python.

* Adding and renaming tests

Adding test case for creating a sublist that encompasses the whole list but uses # and #-end instead of first last (applicable for python). Also, renaming tests.

* Adding contant and fixing python lists bugs

Adding contant for ONE_BASED_INDEXING and fixing bugs in python for lists.

* Fixing test get random

Fixing test get random to take into account indexing for return value.

* Adding indexing checkbox to test page

Adding checkbos on test page so that code can be generated for one and zero based indexing. Languages that are generated with zero based indexing that do not have it implemented will fail tests as expected.

* Fixing unittest getremove random

Fixing unittest getremove random to take into account the return value based on indexing.

* Change comparison for getremove random test

Fixed comparison to equal for the return value for getremove random.

* Fixing bugs with lists zero-indexing

Fixing getIndex and getSublist methods to pass for zero-indexed tests.

* Adding test cases and formatting

Adding test cases to text tests, reordering a couple list test, and formatting block spacing.

* Fixing unittest expected value

Fixing expected value fore unit tests for sublist.

* Cleanup

Removing obvious comments, formatting fixes, and naming in generated code in JS.

* Helper function for Python lists

Adding helper function for casting to int for indices.

* Expanding helper to reduce duplicated code

Expanding helper method to also get the property with the correct order and check indexing to reduce duplicated code.

* Cleaning up JS indexing with helper function

Adding helper function for indexing and used it in lists and text.

* Moving helper function and formatting fixes

Moving helper function, formatting fixes, and changing some generated code variable names.

* Fixing python generation for text

Fixing all failinng tests for python and using new helper method.

* Lint fixes and order in indexOf

Making lint fixes and correcting returned order in indexOf.

* Python variable renaming

Renaming a few generated variables.

* Fixing comment and order

Fixing comment to list Blockly.Block type and fixing order because it could be higher.

* Switching back to if

Switching switch back to if statements because there weren't enough cases to warrant for a switch.

* Adding order and fixing lists for Dart

Adding if null operator to operator precedence for Dart. Also, fixing lists implementation to pass unit tests and adding zero-indexing functionality.

* Formatting and lint fixes

Formatting and lint fixes

* Dart text fixed

Fixing Dart text generation to pass unit tests.

* Changing back  to variable

Changing switch condition back to variable.

* Fixing ORDER_OVERRIDES

Inner and outer order was switched .

* Adding bug with order caused by generator change

Flooring order before comparision because of how the order constants were modified.

* Adding list tests

Adding tests for additional cases for lists/

* Adding comment for dart order

Adding comment for Dart ORDER_IF_NULL operator.

* Formatting fixes

Formatting fixes for line indentation.

* Fixing PHP order and lists generation

Fixing PHP order constants and fixing lists so that they pass unit tests.

* Fixing tests

Removing duplicate unit test

* Adding text tests

Adding tests for text.

* Renaming variable and removing unused variable

Renaming variables from exceptionIndex to errorIndex and removing unused at variable.

* Adding missing function call to test

Adding missing funciton call to test that was causing tests to fail when they shouldn't.

* Fixing PHP text generation

Fixing PHP text code generation so it passes unit tests.

* Formatting fixes

Cleaning up code, renamiing a variable.

* Fixing failing subsequence tests

Fixing JS code that failed for sublist/substring tests.

* Fixing intentation

Fixing indentation.

* Fixing Dart sublist/substring

Fixing sublist/substring to include condiiton where FROM_START  (and not throw error by mistake) when zero-indexed.

* Adding order subtraction test

Adding test for checking order for subtraction x- (y - z) x  - (y + z).

* Updating to new PHP power operator

Updating from pow function to ** operator to clean up code.

* Updating to new removeWhere

Updating removeMatching to removeWhere because new version of Dart now use removeWhere.

* Fix for lua rounding assertequals

Adding check for number in equlity check for comparing number for floats.

* Adding test for copy of list

Adding test that checks the list is copied when a sublist is made first-last.

* Formatting and order fixes

Fixing formatting such as indentation and order fixes.

* Adding comment for clarity

Adding comment about how Lua code generation is not supporting zero indexing.

* Changed variable names in code

Changed variable names to follow style guide and changed for loop variable from n to i as is typical.

* Reducing unecessarily generated functions and renaming variables

Reducing number of generated functions using gensym_ by adding parameters to provided function. Renaming variables to make functions more readble.

* Fixing sublist order and sort variable

Fixing order used for valueToCode for sublist and renaming list variable in sort to match rest of code..

* Fixing order constant order

Removing operator () that was incorrect and addiung ~,

* Fixing order and indentation

Fixing order return fro create lists blocks and fixing indentationn for string array.

* Fixing order and renaming variables

Fixing order to be the correct strength and renaming variables to be more readable/

* Changing assert blocks for unit tests

Changing assert blocks to have a value input instead of a field so there is more flexibility in writing tests.

* Cleaning up and adding missing order tests

Adding tests for order for paramters for list blocks that weren't being tested to uncover bugs. Test were also cleaned up/reorganized/renamed to be more readable and shorter vertically (but lines  wider horizontally).

* Compile error fix and order in Dart generation.

Fixing compile error in generated code and incorrect order in get sublist for Dart.

* Fixing typo in getIndex and invalid parameter name

Fixing type in getIndex where list code should have been appended but instead an undefined variable was added. The parameter in lists_sort was changed to my_list because list is a reserved word in python.

* Fixing order, parenthesis bug, and variable declaration in Lua

Fixing incorrect order in Lua. Fixing bug caused by missing parenthesis around ternary operator in code. Variable code was declared with JavaScript syntax, this was fixed to be valid in Lua.

* Adding tests and formatting tests

Adding missing test for order in text/lists. Changing spacing/order of tests and updating comments.

* Fixing error in code

Changing to correct function call in empy tests and changing test name that was duplicated to be more clear.

* Renamed test helper function

* Fixing order and renaming variable in JS generator

Fixing order for charAt and renaming variable in code list_sort from listCode to list to be consistent with rest of code.

* Fixing order for dart text

Fixing roder for dart charAt

* Cleaning up generated code for Dart getIndex

Cleaning up generated code for Dart getIndex so that helper functions aren't generated unecessarily and adding comments.

* Fixing Dart remove random error

Fixing error caused by remove random implementation in Dart. index should have been x but instead was length - x.

* Fixing unit test blocks

Fixing Lua unit test block that should have just returned the number and removing unecessary checks in other blocks because the constant was defined.

* Fixing Lua assert equals block

string.format was throwing an error if one of the values happened to be a boolean.

* Adding tests for create text with number

Adding test for create text with numbers as parameters

* Fixing lua unit test block

Lua unit test block should have added 1

* Removing indexing setting for Lua tests

Removing setting index setting for Lua generation because it is always one-indexed.

* Fixing order and create text

Fixing failing test caused by improper order and fixed create text to properly convert to string when there is one element.

* Running linter on generator code

Running linter on generator code and fixing spacing/indentation problems.

* Editing comments and removing uneeded parenthesis

Editing and adding comments and removing uneeded parenthesis around ternary operator condition.

* Fixing order and changing variable names

Fixing orders that were incorrect and changing variable names to be more descriptive and consistent across code.

* Adding comment about list support and fixes for PHP

Adding comment about how lists are not fully supported for PHP. Adding missing order to PHP and fixing order errors throughout. Fixing regex for variable matching in lists. Cleaning up variable names to be more readable and consistent with other parts of code.

* Reducing complexity for getremove/remove in JS

Reducing complexity in generated code for getremove/remove in JavaScript by replacing unecessary helper function.

* Fixing spacing before inline comments

Ensuring there are two spaces before inline comments.

* Changing JS list copy for clarity

Changing JavaScript list copy to use slice(0) instead of concat for clarity and to use the same pattern as the other sublist methods.

* Changing generated variable name tmp_x

Changing tmp_x to tmpX to follow closer to the correct style for JavaScript.

* Prefixing empy lines between comment text

Prior to this change, comments with an empty line between text did not have a comment prefix before it, resulting in comment blocks that seemed disjoined although they were for the same block. This change affects how the prefix line function works so that those lines will have the prefix (if applicable) while still taking into account the trailing newline character.

* Changing for loops variable names

Changing most for loops to use i as the variable name (or j if applicable) or changing name to be more readable.

* Simplifying provided subsequence function

Simplifying subsequence function to generate a simpler function depending on where combination instead of a larger complex function that works for all where combinations.

* Style fixes

Fixing indentation, comments, and other formatting-type changes based on pull request comments.

* Fixing indentation

Fixing indentation and removing an extra newline.

* Fixing PHP mode implementation

Fixing PHP mode implementation to properlyu return multiple modes if applicable.

* Fixing line too long

Wrapping lines in php/math.js with lines longer than 80 characters.

* Wrapping long lines

Wrapping lines that are too long.

* Changing boolean casing

Changing boolean casing to be lowercase.
2016-07-08 11:43:48 -07:00
Rachel Fenichel
2364aed716 Distinguish between allVariables and allUsedVariables 2016-07-07 15:23:20 -07:00
Rachel Fenichel
9a6cbe1b34 Lint and remove math_change wherever necessary 2016-07-07 14:40:59 -07:00
Rachel Fenichel
5418843c12 Move the change block to the variables category 2016-07-07 14:39:45 -07:00
Rachel Fenichel
13c6c63daa Create variables from the flyout 2016-07-07 14:39:45 -07:00
Rachel Fenichel
ef4882d90d Add variable deletion as dropdown action 2016-07-07 14:39:45 -07:00
Rachel Fenichel
4a81ecb601 Create variable list, and use it for add and rename 2016-07-07 14:38:56 -07:00
Rachel Fenichel
e371da3031 First pass at svg button in flyout 2016-07-07 14:35:30 -07:00
Neil Fraser
57131165b0 Routine recompile 2016-06-03 16:12:59 -07:00
Neil Fraser
02d60a2dbe Group variable rename into same event. 2016-03-06 14:51:03 -08:00
Neil Fraser
6eb652cf70 Fix persistence of logging in playground. 2016-02-29 15:02:05 -08:00
Neil Fraser
b10ef6da48 Allow custom gaps to be specified between toolbox blocks. 2015-10-25 22:20:08 -04:00
Neil Fraser
ffe49a7020 Remove needless use of .call() 2015-08-25 15:09:55 +01:00
Neil Fraser
c9addf7e31 Improve accuracy of goog.require calls. 2015-02-06 15:27:25 -08:00
Neil Fraser
315a5fc762 Remove global workspace references from variable and procedure utilities. 2015-01-12 14:57:00 -08:00
Neil Fraser
0f8d01209c Headless workspaces and blocks. 2014-12-23 11:22:02 -08:00
Neil Fraser
8c3f180669 Procedure blocks no longer destruct with hardcoded parent (no functional change). 2014-12-18 17:26:08 -08:00
Neil Fraser
0a191c1c50 Convert Blockly.Toolbox from a singleton to an instance. 2014-11-29 15:41:27 -08:00
Neil Fraser
6539211104 Change official project URL. 2014-10-07 13:09:55 -07:00
Neil Fraser
7122410373 Changing project location from Google Code to GitHub. 2014-09-08 15:18:02 -07:00
ellen.spertus
6ee38cdec3 Automatic commit Tue Jan 28 03:00:09 PST 2014 2014-01-28 03:00:09 -08:00
ellen.spertus
c7a1b36c86 Automatic commit Wed Jan 22 03:00:07 PST 2014 2014-01-22 03:00:07 -08:00
ellen.spertus
ea211c5080 Manual commit 2013-12-20 16:25:26 -08:00
ellen.spertus
a8acffd81c New initial commit with .svn directories and their contents ignored. 2013-10-30 14:46:03 -07:00