Commit graph

20 commits

Author SHA1 Message Date
Paul Kaplan
ebc2e9dab7
Merge pull request from paulkaplan/better-touch-comments
More touchable comments, and a few RTL bugfixes
2019-07-31 09:56:52 -04:00
Paul Kaplan
42ab758249 Remove debug stylings 2019-07-30 12:00:23 -04:00
Paul Kaplan
2bf63bacc5 Change resize handle to add a larger hitbox to make touch interactions easier 2019-07-30 11:54:35 -04:00
Paul Kaplan
ef9b4cc2b8 Resize minimize/delete handle icons so they take up the entire topbar height. This makes them much easier to touch 2019-07-30 11:53:33 -04:00
Paul Kaplan
3a992ac697 Mark delete/resize events as noCaptureIdentifier to stop workspace freezing 2019-07-29 13:12:54 -04:00
Ashwin Ramaswami
79b9cf6163 Comment formatting improvements 2018-12-19 08:44:20 -05:00
Karishma Chadha
0fa3ef6e78 Fix RTL block comment positioning and RTL workspace comment rendering 2018-10-02 16:48:58 -04:00
Ikuo Terado
802ce851bd Avoid dragging comment's line 2018-08-10 02:55:41 +09:00
Karishma Chadha
0a453c623a Fix issues with scrolling workspace just after resizing a comment. 2018-06-15 12:59:25 -04:00
Karishma Chadha
5ea7369c35 Add a piece of state to keep track of whether the same icon that had a mouse up event also first had a mouse down event on it. 2018-06-12 14:56:21 -04:00
Karishma Chadha
4ea6cd80fd Change top bar label without removing and then recreating/readding a text node. 2018-06-12 14:56:21 -04:00
Karishma Chadha
2c2970df57 Code cleanup addressing PR comments 2018-06-06 18:45:32 -04:00
Karishma Chadha
3d3b8f3427 Final changes for comment events. Resizing and minimizing/maximizing changes are recorded in CommentChange event. Undo/Redo works for all events. 2018-06-01 17:22:10 -04:00
Karishma Chadha
da55613c52 Add CommentCreate, CommentMove, and CommentDelete events to scratch block comments. 2018-05-31 09:45:45 -04:00
Karishma Chadha
9d7c1df8b0 Swap comment top bar icons in RTL and make minimize arrow icon a little bigger. 2018-05-30 18:13:15 -04:00
Karishma Chadha
c603ef5bba Fix some RTL issues with comments. 2018-05-30 17:34:38 -04:00
Karishma Chadha
f547cbff45 Fix comments. 2018-05-30 15:16:33 -04:00
Karishma Chadha
f55bc764d8 Breaking out scratch bubble rendering into helper functions for rendering subcomponents. 2018-05-30 11:57:41 -04:00
Karishma Chadha
1b5ce1354c Some code cleanup from PR comments. 2018-05-30 11:57:08 -04:00
Karishma Chadha
4afc8e5085 Scratch block comments. 2018-05-25 17:21:31 -04:00