Paul Kaplan
|
e2b6636011
|
Fix offset of comments in stacks
|
2019-12-18 15:42:06 -05:00 |
|
Paul Kaplan
|
fd40039dc8
|
Merge pull request #1971 from paulkaplan/comment-placeholders
Use placeholders instead of default text for comments, fix focusing
|
2019-07-31 09:38:05 -04:00 |
|
Paul Kaplan
|
e0830881f6
|
Force focus after block comments are created
|
2019-07-29 14:41:57 -04:00 |
|
Paul Kaplan
|
c72e6934b4
|
Use placeholders instead of a default value for comments
|
2019-07-29 14:40:57 -04:00 |
|
Paul Kaplan
|
b900bd2742
|
Stop propagation for textarea clicks to make sure preventDefault is not called by workspace event listeners
|
2019-07-29 13:18:01 -04:00 |
|
picklesrus
|
f9b2c35282
|
Allow block comments to be editable on mobile by catching the mousedown event and grabbing focus instead of the mouse up. This makes the experience a bit worse in firefox (you have to click twice to focus the comment now), but fixing this the right way is invovled. See #1631 for full context. (#1757)
|
2018-10-30 16:54:19 -04:00 |
|
Karishma Chadha
|
0fa3ef6e78
|
Fix RTL block comment positioning and RTL workspace comment rendering
|
2018-10-02 16:48:58 -04:00 |
|
Karishma Chadha
|
0e704239b0
|
Change label length to accommodate for the fact that capital letters are bigger.
|
2018-06-20 14:48:07 -04:00 |
|
Karishma Chadha
|
66a844502a
|
Add a character limit to the comment textareas.
|
2018-06-15 17:32:19 -04:00 |
|
kchadha
|
36497c9775
|
Merge pull request #1589 from kchadha/overlapping-comment-fix
Remove explicit z-index from comment foreign body.
|
2018-06-14 18:44:36 -04:00 |
|
Karishma Chadha
|
017f536509
|
Remove explicit z-index from comment foreign body.
|
2018-06-14 17:26:00 -04:00 |
|
Karishma Chadha
|
0c23285ba1
|
Add some clarity to valid number checks.
|
2018-06-14 17:06:16 -04:00 |
|
Karishma Chadha
|
4b8fd27c36
|
Auto position the comment when getXY is called and the comment still needs auto positioning in absence of its bubble having been created.
|
2018-06-14 09:21:44 -04:00 |
|
Karishma Chadha
|
ed05e7bf13
|
ScratchBlockComment constructor should handle NaN inputs.
|
2018-06-14 09:21:44 -04:00 |
|
Karishma Chadha
|
9db85635c4
|
Add visibility annotation to properties, fix reference for this.x_ and this.y_ in ScratchBlockComment
|
2018-06-07 09:23:17 -04:00 |
|
Karishma Chadha
|
437a207721
|
Update CommentChange event to have a consistent API
|
2018-06-06 19:11:09 -04:00 |
|
Karishma Chadha
|
3a94ec57b1
|
Update TODO comment with issue number.
|
2018-06-06 18:52:44 -04:00 |
|
Karishma Chadha
|
2c2970df57
|
Code cleanup addressing PR comments
|
2018-06-06 18:45:32 -04:00 |
|
Karishma Chadha
|
058c68eebb
|
Cleaning up undo and redo of events some more (particularly undo deletion). Setting the size of a comment is separate from setting the visual comment bubble. E.g. minimizing a comment changes the bubble size but not the comment size. Separate this functionaltiy into two separate functions. Creating a comment should also take in stater text. Creating a comment for the first time does not also need to trigger an event for setting the comment text.
|
2018-06-06 15:29:03 -04:00 |
|
Karishma Chadha
|
70d9056fa5
|
Add block comments to workspace.
|
2018-06-06 10:29:43 -04:00 |
|
Karishma Chadha
|
21802e5570
|
Cleanup comment events to reduce code duplication. Fix some issues with undo/redo not emitting events.
|
2018-06-05 14:47:37 -04:00 |
|
Karishma Chadha
|
3d3b8f3427
|
Final changes for comment events. Resizing and minimizing/maximizing changes are recorded in CommentChange event. Undo/Redo works for all events.
|
2018-06-01 17:22:10 -04:00 |
|
Karishma Chadha
|
40f89e11a9
|
Add CommentChange event for block comments and update event names.
|
2018-05-31 09:45:45 -04:00 |
|
Karishma Chadha
|
da55613c52
|
Add CommentCreate, CommentMove, and CommentDelete events to scratch block comments.
|
2018-05-31 09:45:45 -04:00 |
|
Karishma Chadha
|
d33b884fab
|
Make magic numbers slightly less magic...
|
2018-05-30 19:24:18 -04:00 |
|
Karishma Chadha
|
c603ef5bba
|
Fix some RTL issues with comments.
|
2018-05-30 17:34:38 -04:00 |
|
Karishma Chadha
|
f547cbff45
|
Fix comments.
|
2018-05-30 15:16:33 -04:00 |
|
Karishma Chadha
|
1d13bca806
|
Minimized comments should get imported with minimize width instead of provided full size width.
|
2018-05-30 11:58:22 -04:00 |
|
Karishma Chadha
|
1b5ce1354c
|
Some code cleanup from PR comments.
|
2018-05-30 11:57:08 -04:00 |
|
Karishma Chadha
|
118f6bb7b4
|
Minimized state should use positioning (instead of ignoring) if provided.
|
2018-05-30 10:28:44 -04:00 |
|
Karishma Chadha
|
4ac00a97a9
|
Fix functions referring to parent class instead of ScratchBlockComment.
|
2018-05-29 16:20:08 -04:00 |
|
Karishma Chadha
|
4afc8e5085
|
Scratch block comments.
|
2018-05-25 17:21:31 -04:00 |
|