Karishma Chadha
|
1fef923ad4
|
Block and comment events should report language agnostic coordinates so that switching locales (between LTR and RTL languages) does not affect the x position of the blocks and comments on the workspace.
|
2018-10-02 19:13:08 -04:00 |
|
Karishma Chadha
|
5db4c396ce
|
Remove instanceof check when checking for comment minimized state.
|
2018-06-12 14:50:45 -04:00 |
|
Karishma Chadha
|
8e8f41f944
|
Minimize event should work for workspace comments.
|
2018-06-12 14:50:45 -04:00 |
|
Karishma Chadha
|
fa8f12f5b9
|
Remove unnecessary warning.
|
2018-06-07 14:22:23 -04:00 |
|
Karishma Chadha
|
9f954aa925
|
Let CommentChange run multitask.
|
2018-06-07 11:07:02 -04:00 |
|
Karishma Chadha
|
3d21a7724d
|
Update type annotations for comment param in comment events to include ScratchBlockComment
|
2018-06-07 09:18:56 -04:00 |
|
Karishma Chadha
|
437a207721
|
Update CommentChange event to have a consistent API
|
2018-06-06 19:11:09 -04:00 |
|
Karishma Chadha
|
2c2970df57
|
Code cleanup addressing PR comments
|
2018-06-06 18:45:32 -04:00 |
|
Karishma Chadha
|
d583205cdd
|
Remove unnecessary newline.
|
2018-06-06 15:35:15 -04:00 |
|
Karishma Chadha
|
058c68eebb
|
Cleaning up undo and redo of events some more (particularly undo deletion). Setting the size of a comment is separate from setting the visual comment bubble. E.g. minimizing a comment changes the bubble size but not the comment size. Separate this functionaltiy into two separate functions. Creating a comment should also take in stater text. Creating a comment for the first time does not also need to trigger an event for setting the comment text.
|
2018-06-06 15:29:03 -04:00 |
|
Karishma Chadha
|
21802e5570
|
Cleanup comment events to reduce code duplication. Fix some issues with undo/redo not emitting events.
|
2018-06-05 14:47:37 -04:00 |
|
Karishma Chadha
|
acb6f17119
|
Converge some workspace comment and block comment functions.
|
2018-06-01 21:19:33 -04:00 |
|
Karishma Chadha
|
744418feeb
|
Rename comment events file since it pertains to both workspace and block comments.
|
2018-06-01 18:03:33 -04:00 |
|