scratchfoundation/scratch-blocks
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-blocks.git synced 2025-06-08 19:04:20 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions1

Resize minimize/delete handle icons so they take up the entire topbar height. This makes them much easier to touch

Browse source
This commit is contained in:
Paul Kaplan 2019-07-30 11:53:33 -04:00
parent 8d4e38786e
commit ef9b4cc2b8
5 changed files with 12 additions and 12 deletions

6
core/scratch_bubble.js
View file

@ -138,19 +138,19 @@ Blockly.ScratchBubble.TOP_BAR_HEIGHT = 32;
* The size of the minimize arrow icon in the comment top bar.
* @private
*/
Blockly.ScratchBubble.MINIMIZE_ICON_SIZE = 16;
Blockly.ScratchBubble.MINIMIZE_ICON_SIZE = 32;
/**
* The size of the delete icon in the comment top bar.
* @private
*/
Blockly.ScratchBubble.DELETE_ICON_SIZE = 12;
Blockly.ScratchBubble.DELETE_ICON_SIZE = 32;
/**
* The inset for the top bar icons.
* @private
*/
Blockly.ScratchBubble.TOP_BAR_ICON_INSET = 6;
Blockly.ScratchBubble.TOP_BAR_ICON_INSET = 0;
/**
* Create the bubble's DOM.

6
core/workspace_comment_render_svg.js
View file

@ -62,19 +62,19 @@ Blockly.WorkspaceCommentSvg.TOP_BAR_HEIGHT = 32;
* The size of the minimize arrow icon in the comment top bar.
* @private
*/
Blockly.WorkspaceCommentSvg.MINIMIZE_ICON_SIZE = 16;
Blockly.WorkspaceCommentSvg.MINIMIZE_ICON_SIZE = 32;
/**
* The size of the delete icon in the comment top bar.
* @private
*/
Blockly.WorkspaceCommentSvg.DELETE_ICON_SIZE = 12;
Blockly.WorkspaceCommentSvg.DELETE_ICON_SIZE = 32;
/**
* The inset for the top bar icons.
* @private
*/
Blockly.WorkspaceCommentSvg.TOP_BAR_ICON_INSET = 6;
Blockly.WorkspaceCommentSvg.TOP_BAR_ICON_INSET = 0;
/**
* Width that a minimized comment should have.

2
media/comment-arrow-down.svg
View file

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="12px" height="12px" viewBox="0 0 12 12" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<svg width="32px" height="32px" viewBox="-4.5 -6 24 24" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<!-- Generator: Sketch 50.2 (55047) - http://www.bohemiancoding.com/sketch -->
<title>dropdown-caret-up</title>
<desc>Created with Sketch.</desc>

Side by side Swipe

Before

(image error) Size: 880 B

After

(image error) Size: 885 B

Before After
Before After

2
media/comment-arrow-up.svg
View file

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="12px" height="12px" viewBox="0 0 12 12" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<svg width="32px" height="32px" viewBox="-4.5 -6 24 24" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<!-- Generator: Sketch 50.2 (55047) - http://www.bohemiancoding.com/sketch -->
<title>dropdown-caret-down</title>
<desc>Created with Sketch.</desc>

Side by side Swipe

Before

(image error) Size: 972 B

After

(image error) Size: 977 B

Before After
Before After

2
media/delete-x.svg
View file

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<svg width="12px" height="12px" viewBox="0 0 12 12" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<svg width="32px" height="32px" viewBox="-14 -10 32 32" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<!-- Generator: Sketch 50.2 (55047) - http://www.bohemiancoding.com/sketch -->
<title>delete-x</title>
<desc>Created with Sketch.</desc>

Side by side Swipe Overlay

Before

(image error) Size: 1.3 KiB

After

(image error) Size: 1.3 KiB

Before After
Before After