scratchfoundation/scratch-blocks
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-blocks.git synced 2025-08-28 22:10:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Minor wording edits. Fix issue with Voiceover not detecting changes to block labels.

Browse source
This commit is contained in:
Sean Lip 2016-08-23 16:01:25 -07:00
parent aa9dd9646a
commit 3cf06078a2
4 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
accessible/messages.js
View file

@ -52,7 +52,7 @@ Blockly.Msg.TEXT = 'text';
Blockly.Msg.BUTTON = 'button';
Blockly.Msg.DISABLED = 'disabled';
Blockly.Msg.CURRENT_ARGUMENT_VALUE = 'current argument value:';
Blockly.Msg.COPY_TO_WORKSPACE = 'copy to workspace';
Blockly.Msg.COPY_TO_WORKSPACE = 'create new group with this block';
Blockly.Msg.COPY_TO_CLIPBOARD = 'copy to clipboard';
Blockly.Msg.COPY_TO_MARKED_SPOT = 'copy to marked spot';
Blockly.Msg.TOOLBOX = 'Toolbox';

4
accessible/notifications.service.js
View file

@ -36,9 +36,11 @@ blocklyApp.NotificationsService = ng.core
// operations are done in succession, both messages will be read.
this.statusMessage_ = '';
// We need a non-zero timeout here, otherwise NVDA does not read the
// notification messages properly.
var that = this;
setTimeout(function() {
that.statusMessage_ = newMessage;
});
}, 20);
}
});

2
accessible/tree.service.js
View file

@ -233,7 +233,7 @@ blocklyApp.TreeService = ng.core
for (var i = 0; i < workspaceTreeNodes.length; i++) {
if (workspaceTreeNodes[i].id == treeId) {
this.notificationsService.setStatusMessage(
'Now in workspace component ' + (i + 1) + ' of ' +
'Now in workspace group ' + (i + 1) + ' of ' +
workspaceTreeNodes.length);
}
}

2
accessible/workspace-tree.component.js
View file

@ -29,7 +29,7 @@ blocklyApp.WorkspaceTreeComponent = ng.core
selector: 'blockly-workspace-tree',
template: `
<li [id]="idMap['blockRoot']" role="treeitem" class="blocklyHasChildren"
[attr.aria-labelledBy]="generateAriaLabelledByAttr(idMap['blockSummary'], 'blockly-workspace-block')"
[attr.aria-label]="getBlockDescription() + ' ' + ('WORKSPACE_BLOCK'|translate) + ' ' + ('SUBMENU_INDICATOR'|translate)"
[attr.aria-level]="level">
<label [id]="idMap['blockSummary']">{{getBlockDescription()}}</label>