scratchfoundation/scratch-blocks
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-blocks.git synced 2025-08-28 22:10:31 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Do not duplicate IDs on paste

Browse source
This commit is contained in:
Paul Kaplan 2017-06-09 12:55:50 -04:00
parent f6ff6cb5df
commit 01e98dc407
1 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

28
core/workspace_svg.js
View file

@ -901,14 +901,30 @@ Blockly.WorkspaceSvg.prototype.paste = function(xmlBlock) {
Blockly.Events.disable();
try {
var block = Blockly.Xml.domToBlock(xmlBlock, this);
// Rerender to get around problem with IE and Edge not measuring text
// correctly when it is hidden.
if (goog.userAgent.IE || goog.userAgent.EDGE) {
var blocks = block.getDescendants();
for (var i = blocks.length - 1; i >= 0; i--) {
blocks[i].render(false);
var blocks = block.getDescendants();
for (var i = blocks.length - 1; i >= 0; i--) {
var descendant = blocks[i];
// Scratch-specific: Give shadow dom new IDs to prevent duplicating on paste
for(var j = 0; j < descendant.inputList.length; j++) {
if (descendant.inputList[j].connection) {
var connection = descendant.inputList[j].connection;
if (connection && connection.getShadowDom()) {
var shadowDom = connection.getShadowDom();
shadowDom.setAttribute('id', Blockly.utils.genUid());
connection.setShadowDom(shadowDom);
}
}
}
// Rerender to get around problem with IE and Edge not measuring text
// correctly when it is hidden.
if (goog.userAgent.IE || goog.userAgent.EDGE) {
descendant.render(false);
}
}
// Move the duplicate to original position.
var blockX = parseInt(xmlBlock.getAttribute('x'), 10);
var blockY = parseInt(xmlBlock.getAttribute('y'), 10);