scratchfoundation/scratch-audio
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-audio.git synced 2024-12-22 14:02:29 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

cleanup tests a bit

Browse source
This commit is contained in:
Corey Frang 2018-06-21 11:25:27 -04:00 committed by Michael "Z" Goddard
parent 2bd946423b
commit e2da92fae7
No known key found for this signature in database
GPG key ID: 762CD40DD5349872
2 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/GreenPlayer.js
View file

@ -116,11 +116,11 @@ class SoundPlayer extends EventEmitter {
return;
}
if (this.volumeEffect !== null) {
this.volumeEffect.connect(target);
} else {
if (this.volumeEffect === null) {
this.outputNode.disconnect();
this.outputNode.connect(target.getInputNode());
} else {
this.volumeEffect.connect(target);
}
return this;

13
test/SoundPlayer.js
View file

@ -39,14 +39,13 @@ tap.test('SoundPlayer', suite => {
suite.plan(4);
suite.test('play initializes and creates chain', t => {
suite.test('play initializes and creates source node', t => {
t.plan(3);
t.equal(soundPlayer.initialized, false, 'not yet initialized');
soundPlayer.play();
t.equal(soundPlayer.initialized, true, 'now is initialized');
let buffer = audioContext.DECODE_AUDIO_DATA_RESULT.toJSON();
t.deepEqual(soundPlayer.outputNode.toJSON(), {
buffer,
buffer: audioContext.DECODE_AUDIO_DATA_RESULT.toJSON(),
inputs: [],
loop: false,
loopEnd: 0,
@ -65,7 +64,7 @@ tap.test('SoundPlayer', suite => {
t.plan(1);
soundPlayer.play();
soundPlayer.connect(audioEngine);
t.deepEqual(audioEngine.inputNode.toJSON().inputs, [
t.deepEqual(help.engineInputs, [
soundPlayer.outputNode.toJSON()
], 'output node connects to input node');
t.end();
@ -80,7 +79,7 @@ tap.test('SoundPlayer', suite => {
audioContext.$processTo(0);
soundPlayer.stop();
t.equal(soundPlayer.outputNode, null, 'nullify outputNode immediately (taken sound is stopping)');
t.deepEqual(audioEngine.inputNode.toJSON().inputs, [{
t.deepEqual(help.engineInputs, [{
name: 'GainNode',
gain: {
value: 1,
@ -90,13 +89,13 @@ tap.test('SoundPlayer', suite => {
}], 'output node connects to gain node to input node');
audioContext.$processTo(audioEngine.DECAY_TIME / 2);
const engineInputs = audioEngine.inputNode.toJSON().inputs;
const engineInputs = help.engineInputs;
t.notEqual(engineInputs[0].gain.value, 1, 'gain value should not be 1');
t.notEqual(engineInputs[0].gain.value, 0, 'gain value should not be 0');
t.equal(outputNode.$state, 'PLAYING');
audioContext.$processTo(audioEngine.DECAY_TIME);
t.deepEqual(audioEngine.inputNode.toJSON().inputs, [{
t.deepEqual(help.engineInputs, [{
name: 'GainNode',
gain: {
value: 0,