scratchfoundation/scratch-audio
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-audio.git synced 2024-12-22 22:12:48 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Disconnect audio nodes on dispose

Browse source
This commit is contained in:
Eric Rosenbaum 2018-01-09 18:18:49 -05:00
parent 97e099e6de
commit d2b6cb40e3
2 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/effects/PanEffect.js
View file

@ -52,6 +52,16 @@ class PanEffect {
connect (node) {
this.channelMerger.connect(node);
}
/**
* Clean up and disconnect audio nodes.
*/
dispose () {
this.input.disconnect();
this.leftGain.disconnect();
this.rightGain.disconnect();
this.channelMerger.disconnect();
}
}
module.exports = PanEffect;

8
src/index.js
View file

@ -133,6 +133,14 @@ class AudioPlayer {
if (this.audioEngine === null) return;
this.effectsNode.gain.setTargetAtTime(value / 100, 0, this.audioEngine.DECAY_TIME);
}
/**
* Clean up and disconnect audio nodes.
*/
dispose () {
this.panEffect.dispose();
this.effectsNode.disconnect();
}
}