scratchfoundation/scratch-audio
1
0
Fork 0
mirror of https://github.com/scratchfoundation/scratch-audio.git synced 2024-12-22 14:02:29 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Better order of stop/connect/play

Browse source
This commit is contained in:
Corey Frang 2018-06-21 11:13:04 -04:00
parent ea6093835c
commit c8f3510713
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/SoundBank.js
View file

@ -90,11 +90,17 @@ class SoundBank {
const effects = this.getSoundEffects(soundId); const effects = this.getSoundEffects(soundId);
const player = this.getSoundPlayer(soundId); const player = this.getSoundPlayer(soundId);
this.playerTargets.set(soundId, target); if (this.playerTargets.get(soundId) !== target) {
effects.setEffectsFromTarget(target); // make sure to stop the old sound, effectively "forking" the output
effects.addSoundPlayer(player); // when the target switches before we adjust it's effects
player.stop();
}
this.playerTargets.set(soundId, target);
effects.addSoundPlayer(player);
effects.setEffectsFromTarget(target);
player.connect(effects); player.connect(effects);
player.play(); player.play();
return player.finished(); return player.finished();