mirror of
https://github.com/scratchfoundation/scratch-audio.git
synced 2024-12-22 14:02:29 -05:00
Merge pull request #100 from mzgoddard/todo-remove-this
remove `@todo` remove this items in AudioEngine
This commit is contained in:
commit
7e61890c1b
1 changed files with 0 additions and 38 deletions
|
@ -207,36 +207,6 @@ class AudioEngine {
|
|||
.then(([id, buffer]) => new SoundPlayer(this, {id, buffer}));
|
||||
}
|
||||
|
||||
/**
|
||||
* Retrieve the audio buffer as held in memory for a given sound id.
|
||||
* @todo remove this
|
||||
*/
|
||||
getSoundBuffer () {
|
||||
// todo: Deprecate audioBuffers. If something wants to hold onto the
|
||||
// buffer, it should. Otherwise buffers need to be able to release their
|
||||
// decoded memory to avoid running out of memory which is possible with
|
||||
// enough large audio buffers as they are full 16bit pcm waveforms for
|
||||
// each audio channel.
|
||||
log.warn('The getSoundBuffer function is no longer available. Use soundBank.getSoundPlayer().buffer.');
|
||||
}
|
||||
|
||||
/**
|
||||
* Add or update the in-memory audio buffer to a new one by soundId.
|
||||
* @todo remove this
|
||||
*/
|
||||
updateSoundBuffer () {
|
||||
log.warn('The updateSoundBuffer function is no longer available. Use soundBank.getSoundPlayer().buffer.');
|
||||
}
|
||||
|
||||
/**
|
||||
* An older version of the AudioEngine had this function to load all sounds
|
||||
* This is a stub to provide a warning when it is called
|
||||
* @todo remove this
|
||||
*/
|
||||
loadSounds () {
|
||||
log.warn('The loadSounds function is no longer available. Please use Scratch Storage.');
|
||||
}
|
||||
|
||||
/**
|
||||
* Get the current loudness of sound received by the microphone.
|
||||
* Sound is measured in RMS and smoothed.
|
||||
|
@ -251,14 +221,6 @@ class AudioEngine {
|
|||
return this.loudness.getLoudness();
|
||||
}
|
||||
|
||||
/**
|
||||
* Deprecated way to create an AudioPlayer
|
||||
* @todo remove this
|
||||
*/
|
||||
createPlayer () {
|
||||
log.warn('the createPlayer method is no longer available, please use createBank');
|
||||
}
|
||||
|
||||
/**
|
||||
* Create an effect chain.
|
||||
* @returns {EffectChain} chain of effects defined by this AudioEngine
|
||||
|
|
Loading…
Reference in a new issue