Merge pull request #182 from scratchfoundation/renovate/eslint-config-scratch-9.x

chore(deps): update dependency eslint-config-scratch to v9

package.json

@@ -28,11 +28,11 @@
   },
   "devDependencies": {
     "babel-core": "6.26.3",
-    "babel-eslint": "7.2.3",
+    "babel-eslint": "10.1.0",
     "babel-loader": "7.1.5",
     "babel-preset-env": "1.7.0",
-    "eslint": "3.19.0",
-    "eslint-config-scratch": "3.1.0",
+    "eslint": "8.0.1",
+    "eslint-config-scratch": "9.0.3",
     "json": "9.0.6",
     "tap": "12.7.0",
     "web-audio-test-api": "0.5.2",

src/ADPCMSoundDecoder.js

@@ -89,7 +89,7 @@ class ADPCMSoundDecoder {
      * Decode an ADPCM sound stored in an ArrayBuffer and return a promise
      * with the decoded audio buffer.
      * @param  {ArrayBuffer} audioData - containing ADPCM encoded wav audio
-     * @return {AudioBuffer} the decoded audio buffer
+     * @return {Promise.<AudioBuffer>} the decoded audio buffer
      */
     decode (audioData) {
 
@@ -99,7 +99,7 @@ class ADPCMSoundDecoder {
             const riffStr = stream.readUint8String(4);
             if (riffStr !== 'RIFF') {
                 log.warn('incorrect adpcm wav header');
-                reject();
+                reject(new Error('incorrect adpcm wav header'));
             }
 
             const lengthInHeader = stream.readInt32();
@@ -110,7 +110,7 @@ class ADPCMSoundDecoder {
             const wavStr = stream.readUint8String(4);
             if (wavStr !== 'WAVE') {
                 log.warn('incorrect adpcm wav header');
-                reject();
+                reject(new Error('incorrect adpcm wav header'));
             }
 
             const formatChunk = this.extractChunk('fmt ', stream);
@@ -168,7 +168,7 @@ class ADPCMSoundDecoder {
         const available = compressedData.getBytesAvailable();
         const blocks = (available / blockSize) | 0;
         // Number of samples in full blocks.
-        const fullBlocks = blocks * (2 * (blockSize - 4)) + 1;
+        const fullBlocks = (blocks * (2 * (blockSize - 4))) + 1;
         // Number of samples in the last incomplete block. 0 if the last block
         // is full.
         const subBlock = Math.max((available % blockSize) - 4, 0) * 2;
@@ -216,7 +216,7 @@ class ADPCMSoundDecoder {
                 // read 4-bit code and compute delta from previous sample
                 lastByte = compressedData.readUint8();
                 code = lastByte & 0xF;
-                delta = DELTA_TABLE[index * 16 + code];
+                delta = DELTA_TABLE[(index * 16) + code];
                 // compute next index
                 index += INDEX_TABLE[code];
                 if (index > 88) index = 88;
@@ -230,7 +230,7 @@ class ADPCMSoundDecoder {
                 // use 4-bit code from lastByte and compute delta from previous
                 // sample
                 code = (lastByte >> 4) & 0xF;
-                delta = DELTA_TABLE[index * 16 + code];
+                delta = DELTA_TABLE[(index * 16) + code];
                 // compute next index
                 index += INDEX_TABLE[code];
                 if (index > 88) index = 88;

src/ArrayBufferStream.js

@@ -95,7 +95,6 @@ class ArrayBufferStream {
      */
     set position (value) {
         this._position = value + this.start;
-        return value;
     }
 
     /**

src/SoundBank.js

@@ -150,7 +150,7 @@ class SoundBank {
         this.soundEffects.forEach(effects => effects.dispose());
         this.soundEffects.clear();
         for (const soundId in this.soundPlayers) {
-            if (this.soundPlayers.hasOwnProperty(soundId)) {
+            if (Object.prototype.hasOwnProperty.call(this.soundPlayers, soundId)) {
                 this.soundPlayers[soundId].dispose();
             }
         }

src/effects/PitchEffect.js

@@ -118,7 +118,7 @@ class PitchEffect extends Effect {
         if (!players) return;
 
         for (const id in players) {
-            if (players.hasOwnProperty(id)) {
+            if (Object.prototype.hasOwnProperty.call(players, id)) {
                 this.updatePlayer(players[id]);
             }
         }