From 93d3214a357634154dd72549503cd62afdbee4a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrg=20Lehni?= Date: Wed, 18 May 2011 10:04:46 +0100 Subject: [PATCH 1/2] Fix porting error in GradientStop. --- src/color/GradientStop.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/color/GradientStop.js b/src/color/GradientStop.js index 5878a64c..5500078f 100644 --- a/src/color/GradientStop.js +++ b/src/color/GradientStop.js @@ -42,6 +42,6 @@ var GradientStop = this.GradientStop = Base.extend({ equals: function(stop) { return stop == this || stop instanceof GradientStop && this._color.equals(stop._color) - && rampPoint == stop._rampPoint; + && this._rampPoint == stop._rampPoint; } }); From 86ca1ed1e7d8c77d9b9f5c562c62b62e664eacc7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrg=20Lehni?= Date: Wed, 18 May 2011 15:37:01 +0100 Subject: [PATCH 2/2] Add comment explaining color conversion code. --- src/color/Color.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/color/Color.js b/src/color/Color.js index 24ea2038..5380caa5 100644 --- a/src/color/Color.js +++ b/src/color/Color.js @@ -292,6 +292,10 @@ var Color = this.Color = Base.extend(new function() { } }; }, new function() { + // Injection scope to produce conversion methods for the various color + // components known by the possible color types. Requesting any of these + // components on any color internally converts the color to the required + // type and then returns its component, using bean access. return Base.each({ rgb: ['red', 'green', 'blue'], hsb: ['hue', 'saturation', 'brightness'],