scratchfoundation/golangci-lint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/golangci-lint.git synced 2025-08-28 22:28:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

nolintlint: allow to fix //nolint lines (#1583)

Browse source
This commit is contained in:
Andrew Shannon Brown 2021-03-12 20:11:05 -08:00 • committed by GitHub
parent d28c66672e
commit e1a734e559
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 345 additions and 132 deletions
Download patch file Download diff file Expand all files Collapse all files

18
pkg/result/processors/nolint_test.go
View file

@ -291,6 +291,17 @@ func TestNolintUnused(t *testing.T) {
ExpectedNoLintLinter: "varcheck",
}
// the issue below is another nolintlint issue that would be generated for the test file
nolintlintIssueVarcheckUnusedOK := result.Issue{
Pos: token.Position{
Filename: fileName,
Line: 5,
},
FromLinter: golinters.NolintlintName,
ExpectNoLint: true,
ExpectedNoLintLinter: "varcheck",
}
t.Run("when an issue does not occur, it is not removed from the nolintlint issues", func(t *testing.T) {
p := createProcessor(t, log, []string{"nolintlint", "varcheck"})
defer p.Finish()
@ -298,6 +309,13 @@ func TestNolintUnused(t *testing.T) {
processAssertSame(t, p, nolintlintIssueVarcheck)
})
t.Run("when an issue does not occur but nolintlint is nolinted, it is removed from the nolintlint issues", func(t *testing.T) {
p := createProcessor(t, log, []string{"nolintlint", "varcheck"})
defer p.Finish()
processAssertEmpty(t, p, nolintlintIssueVarcheckUnusedOK)
})
t.Run("when an issue occurs, it is removed from the nolintlint issues", func(t *testing.T) {
p := createProcessor(t, log, []string{"nolintlint", "varcheck"})
defer p.Finish()