fix: combination of --fix and --path-prefix ()

Co-authored-by: Fernandez Ludovic <ldez@users.noreply.github.com>
This commit is contained in:
Patrick Ohly 2023-03-20 21:44:36 +01:00 committed by GitHub
parent 076f6b911d
commit d92b38cc3e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 70 additions and 20 deletions

View file

@ -14,7 +14,9 @@ import (
// value: "1"
const envKeepTempFiles = "GL_KEEP_TEMP_FILES"
func TestFix(t *testing.T) {
func setupTestFix(t *testing.T) []string {
t.Helper()
testshared.SkipOnWindows(t)
tmpDir := filepath.Join(testdataDir, "fix.tmp")
@ -33,7 +35,11 @@ func TestFix(t *testing.T) {
testshared.InstallGolangciLint(t)
sources := findSources(t, tmpDir, "in", "*.go")
return findSources(t, tmpDir, "in", "*.go")
}
func TestFix(t *testing.T) {
sources := setupTestFix(t)
for _, input := range sources {
input := input
@ -47,13 +53,49 @@ func TestFix(t *testing.T) {
}
testshared.NewRunnerBuilder(t).
WithArgs(
"--disable-all",
WithArgs("--disable-all",
"--print-issued-lines=false",
"--print-linter-name=false",
"--out-format=line-number",
"--fix",
).
"--fix").
WithRunContext(rc).
WithTargetPath(input).
Runner().
Run().
ExpectExitCode(rc.ExitCode)
output, err := os.ReadFile(input)
require.NoError(t, err)
expectedOutput, err := os.ReadFile(filepath.Join(testdataDir, "fix", "out", filepath.Base(input)))
require.NoError(t, err)
require.Equal(t, string(expectedOutput), string(output))
})
}
}
func TestFix_pathPrefix(t *testing.T) {
sources := setupTestFix(t)
for _, input := range sources {
input := input
t.Run(filepath.Base(input), func(t *testing.T) {
t.Parallel()
rc := testshared.ParseTestDirectives(t, input)
if rc == nil {
t.Logf("Skipped: %s", input)
return
}
testshared.NewRunnerBuilder(t).
WithArgs("--disable-all",
"--print-issued-lines=false",
"--print-linter-name=false",
"--out-format=line-number",
"--fix",
"--path-prefix=foobar/").
WithRunContext(rc).
WithTargetPath(input).
Runner().